From: Azat Khuzhin <a3at.mail@gmail.com>
To: Theodore Ts'o <tytso@mit.edu>
Cc: linux-ext4@vger.kernel.org, lists2009@fnarfbargle.com
Subject: Re: [PATCH] resize2fs: fix 32bit overflow during minimal size calculation for 64bit fs.
Date: Sun, 27 Jul 2014 22:21:44 +0400 [thread overview]
Message-ID: <20140727182028.GE24045@azat> (raw)
In-Reply-To: <20140726215341.GU6725@thunk.org>
On Sat, Jul 26, 2014 at 05:53:41PM -0400, Theodore Ts'o wrote:
> On Sat, Jul 26, 2014 at 11:19:27AM +0400, Azat Khuzhin wrote:
> > calculate_minimum_resize_size() multiplying two 32bit numbers, however the
> > result must be 64bit, but it will be truncated to 32bit, and because of this
> > data_blocks will be zero, and it will never leave loop...
>
> There is a much more general patch which solves a number of other
> instances where this bug exists which I've already committed into my
> tree:
>
> https://git.kernel.org/cgit/fs/ext2/e2fsprogs.git/commit/?h=maint&id=1e33a8b408123a4e02a6b9135807f6fd61f3e235
Yeah, I didn't thought about fixing *all* places of this bug.
Thanks,
Azat.
prev parent reply other threads:[~2014-07-27 18:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-26 7:19 [PATCH] resize2fs: fix 32bit overflow during minimal size calculation for 64bit fs Azat Khuzhin
2014-07-26 21:53 ` Theodore Ts'o
2014-07-27 18:21 ` Azat Khuzhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140727182028.GE24045@azat \
--to=a3at.mail@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=lists2009@fnarfbargle.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox