Re: [PATCH] ext4: add sysfs entry showing whether the fs contains errors

Nikola Ciprich
2014-05-20T09:47:58Z

[-- Attachment #1: Type: text/plain, Size: 1967 bytes --]

Hello Lukáš,

just wanted to ask about the status of this patch.. it didn't make it
to git yet, did it? Do you plan to make some changes to it? I'm eager
to test it ;-)

cheers

nik

On Wed, May 07, 2014 at 10:44:34AM +0200, Lukáš Czerner wrote:
> On Tue, 6 May 2014, Theodore Ts'o wrote:
>
> > Date: Tue, 6 May 2014 15:23:26 -0400
> > From: Theodore Ts'o <tytso@mit.edu>
> > To: Darrick J. Wong <darrick.wong@oracle.com>
> > Cc: Lukas Czerner <lczerner@redhat.com>, linux-ext4@vger.kernel.org,
> > nikola.ciprich@linuxbox.cz
> > Subject: Re: [PATCH] ext4: add sysfs entry showing whether the fs contains
> > errors
> >
> > On Tue, May 06, 2014 at 10:43:01AM -0700, Darrick J. Wong wrote:
> > >
> > > Minor complaint: "contains" makes me think that cat'ing that file will return
> > > either 0 or 1, not a string of error text. Perhaps we could shorten it to
> > > /sys/fs/ext4/sda/errors ?
> >
> > What I'd suggest doing is simply calling it errors_count, and
> > returning s_error_count. While we're at it, we could also return
> > s_first_error_time and s_last_error_time as well, since I imagine
> > those would could be quite useful for someone trying to create a
> > system health monitoring daemon.
> >
> > Cheers,
> >
> > - Ted
>
> Right now I am using the same function which prints this information
> to the log. So I am going to use simpler output for the sysfs.
>
> <error count> <first time> <function>:<line> <last time> <function>:<line>
>
> That should be easy to parse. I think that just calling it errors is
> good enough.
>
> Thanks!
> -Lukas
>

--
-------------------------------------
Ing. Nikola CIPRICH
LinuxBox.cz, s.r.o.
28.rijna 168, 709 00 Ostrava

tel.: +420 591 166 214
fax: +420 596 621 273
mobil: +420 777 093 799
www.linuxbox.cz

mobil servis: +420 737 238 656
email servis: servis@linuxbox.cz
-------------------------------------

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]