Re: [PATCH] ext4: add sysfs entry showing whether the fs contains errors

Theodore Ts'o
2014-05-06T19:23:33Z

On Tue, May 06, 2014 at 10:43:01AM -0700, Darrick J. Wong wrote:
>
> Minor complaint: "contains" makes me think that cat'ing that file will return
> either 0 or 1, not a string of error text. Perhaps we could shorten it to
> /sys/fs/ext4/sda/errors ?

What I'd suggest doing is simply calling it errors_count, and
returning s_error_count. While we're at it, we could also return
s_first_error_time and s_last_error_time as well, since I imagine
those would could be quite useful for someone trying to create a
system health monitoring daemon.

Cheers,

- Ted