From: Theodore Ts'o <tytso@mit.edu>
To: Andreas Dilger <adilger@dilger.ca>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>,
Azat Khuzhin <a3at.mail@gmail.com>,
Eric Sandeen <sandeen@redhat.com>
Subject: Re: [PATCH] tune2fs: fix uninitialized variable in remove_journal_device
Date: Fri, 1 Aug 2014 21:32:06 -0400 [thread overview]
Message-ID: <20140802013206.GC27252@thunk.org> (raw)
In-Reply-To: <6FF7A658-00C4-4185-A182-E9895E704A3E@dilger.ca>
On Fri, Aug 01, 2014 at 08:38:30AM +0200, Andreas Dilger wrote:
> > /* Write back the journal superblock */
> > - if ((retval = io_channel_write_blk64(jfs->io, start,
> > - -SUPERBLOCK_SIZE, buf))) {
> > + if ((retval = io_channel_write_blk64(jfs->io,
> > + ext2fs_journal_sb_start(fs->blocksize),
> > + -SUPERBLOCK_SIZE, buf))) {
>
> Better to also remove assignment in conditional check.
Good point, done.
- Ted
next prev parent reply other threads:[~2014-08-02 1:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-28 7:43 [PATCH 0/4 v3] e2fsprogs journal fixes (UUID and 1k block size issue) Azat Khuzhin
2014-07-28 7:43 ` [PATCH 1/4 v3] journal: use consts instead of 1024 and add helper for journal with 1k blocksize Azat Khuzhin
2014-07-28 7:43 ` [PATCH 2/4 v3] tune2fs: remove_journal_device(): use the correct block to find jsb Azat Khuzhin
2014-07-28 7:43 ` [PATCH 3/4 v3] tune2fs: update journal super block when changing UUID for fs Azat Khuzhin
2014-07-31 15:16 ` Eric Sandeen
2014-07-31 15:45 ` Azat Khuzhin
2014-08-01 6:40 ` Andreas Dilger
2014-07-31 15:53 ` [PATCH] tune2fs: fix uninitialized variable in remove_journal_device Theodore Ts'o
2014-08-01 6:38 ` Andreas Dilger
2014-08-02 1:32 ` Theodore Ts'o [this message]
2014-07-28 7:43 ` [PATCH 4/4 v3] tune2fs: update journal users while updating fs UUID (with external journal) Azat Khuzhin
2014-07-28 20:07 ` [PATCH 0/4 v3] e2fsprogs journal fixes (UUID and 1k block size issue) Andreas Dilger
2014-07-28 21:05 ` Theodore Ts'o
2014-07-29 11:36 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140802013206.GC27252@thunk.org \
--to=tytso@mit.edu \
--cc=a3at.mail@gmail.com \
--cc=adilger@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).