linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Theodore Ts'o <tytso@mit.edu>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>,
	Dan Jacobson <jidanni@jidanni.org>
Subject: Re: [PATCH v2] e2fsck: don't flush the FS unless it's actually dirty
Date: Tue, 12 Aug 2014 14:39:49 -0400	[thread overview]
Message-ID: <20140812183949.GH12871@thunk.org> (raw)
In-Reply-To: <20140812171707.GI2808@birch.djwong.org>

On Tue, Aug 12, 2014 at 10:17:07AM -0700, Darrick J. Wong wrote:
> ext2fs_flush2() unconditionally writes the block group descriptors to
> disk even if the underlying FS isn't marked dirty.  This causes the
> following error message on a fsck -n run:...
> 
> v2: Fix test to use $CRCSUM instead of md5sum.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>

Thanks, applied.

As it turns out, I was wrong; there were other users of md5sum in the
tests that I had forgotten about.  Now that we have crcsum, it makes
sense to convert them over to use md5sum as well, so I'll do that.

Thanks again,

						- Ted

  reply	other threads:[~2014-08-12 18:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-12 17:17 [PATCH v2] e2fsck: don't flush the FS unless it's actually dirty Darrick J. Wong
2014-08-12 18:39 ` Theodore Ts'o [this message]
2014-08-12 18:44   ` [PATCH] tests: convert use of md5sum to crcsum Theodore Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140812183949.GH12871@thunk.org \
    --to=tytso@mit.edu \
    --cc=darrick.wong@oracle.com \
    --cc=jidanni@jidanni.org \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).