From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: tytso@mit.edu, darrick.wong@oracle.com
Cc: linux-ext4@vger.kernel.org
Subject: [PATCH 0/2] jbd2 checksum-related fixes
Date: Fri, 15 Aug 2014 13:43:46 -0700 [thread overview]
Message-ID: <20140815204346.16444.14064.stgit@birch.djwong.org> (raw)
Hi all,
This is a pair of patches to jbd2 that fix some problems that have
been found when journal checksumming is enabled.
Patch 1 fixes a longstanding bug -- journal recovery goes into an
infinite loop when a non-revoked journal block fails its metadata
checksum test. Instead, keep replaying the journal and proceed to the
e2fsck.
Patch 2 introduces journal_csum v3 to fix numerous journal block
tag size handling bugs. The test of 64bitness should not rely on
guessing the tag size when it could simply query the feature flags.
Furthermore, the journal_csum v2 structure had memory access alignment
issues. Just replace this all with a 16-byte tag with everything in
it; the overhead for checksums is no more than 0.1%.
Patches are against 3.16, and have been xfstest'd and checked against
debugfs creating test journals (see e2fsprogs patchbomb 5.1 later
tonight).
Comments and questions are, as always, welcome.
--D
next reply other threads:[~2014-08-15 20:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-15 20:43 Darrick J. Wong [this message]
2014-08-15 20:43 ` [PATCH 1/2] jbd2: fix infinite loop when recovering corrupt journal blocks Darrick J. Wong
2014-08-26 2:44 ` Theodore Ts'o
2014-08-15 20:43 ` [PATCH 2/2] jbd2: fix descriptor block size handling errors with journal_csum Darrick J. Wong
2014-08-26 2:44 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140815204346.16444.14064.stgit@birch.djwong.org \
--to=darrick.wong@oracle.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).