From: Jan Kara <jack@suse.cz>
To: Chin-Tsung Cheng <chintzung@gmail.com>
Cc: jack@suse.cz, akpm@linux-foundation.org,
adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ext3: Count internal journal as bsddf overhead in ext3_statfs
Date: Tue, 19 Aug 2014 23:20:13 +0200 [thread overview]
Message-ID: <20140819212013.GA3271@quack.suse.cz> (raw)
In-Reply-To: <1408088971-3221-1-git-send-email-chintzung@gmail.com>
On Fri 15-08-14 15:49:31, Chin-Tsung Cheng wrote:
> The journal blocks of external journal device should not
> be counted as overhead.
Thanks. I've added the patch to my tree.
Honza
>
> Signed-off-by: Chin-Tsung Cheng <chintzung@gmail.com>
> ---
> fs/ext3/super.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/fs/ext3/super.c b/fs/ext3/super.c
> index 08cdfe5..622e882 100644
> --- a/fs/ext3/super.c
> +++ b/fs/ext3/super.c
> @@ -2828,8 +2828,9 @@ static int ext3_statfs (struct dentry * dentry, struct kstatfs * buf)
> */
> overhead += ngroups * (2 + sbi->s_itb_per_group);
>
> - /* Add the journal blocks as well */
> - overhead += sbi->s_journal->j_maxlen;
> + /* Add the internal journal blocks as well */
> + if (sbi->s_journal && !sbi->journal_bdev)
> + overhead += sbi->s_journal->j_maxlen;
>
> sbi->s_overhead_last = overhead;
> smp_wmb();
> --
> 1.9.3
>
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
prev parent reply other threads:[~2014-08-19 21:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-15 7:49 [PATCH] ext3: Count internal journal as bsddf overhead in ext3_statfs Chin-Tsung Cheng
2014-08-19 21:20 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140819212013.GA3271@quack.suse.cz \
--to=jack@suse.cz \
--cc=adilger.kernel@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=chintzung@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).