From: Theodore Ts'o <tytso@mit.edu>
To: gnehzuil.liu@gmail.com
Cc: linux-ext4@vger.kernel.org
Subject: Potential bug in fs/ext4/inline.c?
Date: Thu, 21 Aug 2014 18:01:26 -0400 [thread overview]
Message-ID: <20140821220126.GA3597@thunk.org> (raw)
In ext4_find_inline_entry(), there is the following:
if (ext4_get_inline_size(dir) == EXT4_MIN_INLINE_DATA_SIZE)
goto out;
Am I missing something, or shouldn't this be:
if (ext4_get_inline_size(dir) <= EXT4_MIN_INLINE_DATA_SIZE)
goto out;
?
Thanks,
- Ted
next reply other threads:[~2014-08-21 22:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-21 22:01 Theodore Ts'o [this message]
2014-08-22 4:02 ` Potential bug in fs/ext4/inline.c? Darrick J. Wong
2014-08-22 7:29 ` Zheng Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140821220126.GA3597@thunk.org \
--to=tytso@mit.edu \
--cc=gnehzuil.liu@gmail.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).