From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: "Theodore Ts'o" <tytso@mit.edu>
Cc: gnehzuil.liu@gmail.com, linux-ext4@vger.kernel.org
Subject: Re: Potential bug in fs/ext4/inline.c?
Date: Thu, 21 Aug 2014 21:02:46 -0700 [thread overview]
Message-ID: <20140822040246.GA12576@birch.djwong.org> (raw)
In-Reply-To: <20140821220126.GA3597@thunk.org>
On Thu, Aug 21, 2014 at 06:01:26PM -0400, Theodore Ts'o wrote:
> In ext4_find_inline_entry(), there is the following:
>
> if (ext4_get_inline_size(dir) == EXT4_MIN_INLINE_DATA_SIZE)
> goto out;
>
> Am I missing something, or shouldn't this be:
>
> if (ext4_get_inline_size(dir) <= EXT4_MIN_INLINE_DATA_SIZE)
> goto out;
>
> ?
I'm not sure it matters, since I see:
EXT4_I(inode)->i_inline_size = len + EXT4_MIN_INLINE_DATA_SIZE
scattered all over the code. I'm not sure I like the idea that both ext4 and
e2fsprogs think that the inline data size is never <= 60, but afaict it doesn't
cause any problems.
--D
>
> Thanks,
>
> - Ted
>
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-08-22 4:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-21 22:01 Potential bug in fs/ext4/inline.c? Theodore Ts'o
2014-08-22 4:02 ` Darrick J. Wong [this message]
2014-08-22 7:29 ` Zheng Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140822040246.GA12576@birch.djwong.org \
--to=darrick.wong@oracle.com \
--cc=gnehzuil.liu@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).