From: Theodore Ts'o <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH 1/3] ext4: pass allocation_request struct to ext4_(alloc,splice)_branch
Date: Wed, 3 Sep 2014 13:17:21 -0400 [thread overview]
Message-ID: <20140903171721.GG2504@thunk.org> (raw)
In-Reply-To: <20140903162552.GD17066@quack.suse.cz>
On Wed, Sep 03, 2014 at 06:25:52PM +0200, Jan Kara wrote:
> This seems to suggest ext4_new_meta_blocks() would be better off by
> taking allocation_request argument as well?
I thought about it, but the problem is that ext4_new_meta_blocks() is
called in many more places than ext4_alloc_branch(). So in this
patch, it was just a metter of moving some code from one function to
its (single) caller.
In the case of ext4_new_meta_blocks(), we would needing to replicate
that that code in four or five places, and we were passing in the
mb_flags field anyway, so it wasn't a case of needing to add yet
another argument to a function that had many more arguments to start
with. So I decided it wasn't worth the effort.
Cheers,
- Ted
next prev parent reply other threads:[~2014-09-03 17:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-02 22:05 [PATCH 0/3] Clean up the EXT4_STATE_DELALLOC_RESERVED state flag Theodore Ts'o
2014-09-02 22:05 ` [PATCH 1/3] ext4: pass allocation_request struct to ext4_(alloc,splice)_branch Theodore Ts'o
2014-09-03 16:25 ` Jan Kara
2014-09-03 17:17 ` Theodore Ts'o [this message]
2014-09-02 22:05 ` [PATCH 2/3] ext4: prepare to drop EXT4_STATE_DELALLOC_RESERVED Theodore Ts'o
2014-09-03 16:26 ` Jan Kara
2014-09-02 22:05 ` [PATCH 3/3] ext4: drop the EXT4_STATE_DELALLOC_RESERVED flag Theodore Ts'o
2014-09-03 16:26 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140903171721.GG2504@thunk.org \
--to=tytso@mit.edu \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).