From: Theodore Ts'o <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: Yuanhan Liu <yuanhan.liu@linux.intel.com>,
linux-ext4@vger.kernel.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH] jbd2: remove __jbd2_journal_clean_checkpoint_list to solve scalability issue
Date: Thu, 11 Sep 2014 10:13:57 -0400 [thread overview]
Message-ID: <20140911141357.GA29020@thunk.org> (raw)
In-Reply-To: <20140911135147.GD30901@quack.suse.cz>
On Thu, Sep 11, 2014 at 03:51:47PM +0200, Jan Kara wrote:
>
> I'm not yet convinced that just dropping
> __jbd2_journal_clean_checkpoint_list() is the right thing to do. Some
> periodic cleaning of checkpointed entries would seem reasonable so that we
> don't save all that work for the moment we run out of space in the journal.
> I'll think how to do that in a more efficient way...
I'm sure Jan is aware of this, but for those following along, when we
completely run out of space in the journal, and we have to do a formal
checkpoint operation --- at which point, all file system activity has
to grind to a halt, at which point *all* of the CPU cores will be dead
in the water, which is bad for scalability, not to mention really
annoying users whose terminals are stalled or whose web requests are
completely stuck until the checkpoint completes. :-)
So being able to clean up the journal so we don't have to do a forced
checkpoint operation which requires waiting for I/O operations is
rather important from a performance and usability point of view....
Cheers,
- Ted
next prev parent reply other threads:[~2014-09-11 14:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-11 10:09 [PATCH] jbd2: remove __jbd2_journal_clean_checkpoint_list to solve scalability issue Yuanhan Liu
2014-09-11 13:51 ` Jan Kara
2014-09-11 14:13 ` Theodore Ts'o [this message]
2014-09-11 15:45 ` Yuanhan Liu
2014-09-12 9:40 ` Jan Kara
2014-09-15 3:38 ` Yuanhan Liu
2014-09-16 11:05 ` Jan Kara
2014-09-17 8:14 ` Yuanhan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140911141357.GA29020@thunk.org \
--to=tytso@mit.edu \
--cc=ak@linux.intel.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).