From: Theodore Ts'o <tytso@mit.edu>
To: Andreas Dilger <adilger@dilger.ca>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>,
Dexuan Cui <decui@microsoft.com>
Subject: Re: [PATCH 2/3] ext4: support freezing ext2 (nojournal) file systems
Date: Thu, 18 Sep 2014 17:13:25 -0400 [thread overview]
Message-ID: <20140918211325.GC26995@thunk.org> (raw)
In-Reply-To: <DF6FF9BB-702A-423B-B64E-2731A0347AE8@dilger.ca>
On Thu, Sep 18, 2014 at 02:46:34PM -0600, Andreas Dilger wrote:
> > + if (journal)
> > + /* we rely on upper layer to stop further updates */
> > + jbd2_journal_unlock_updates(EXT4_SB(sb)->s_journal);
>
> This could use "journal" directly instead of "EXT4_SB(sb)->s_journal"
Good point, done.
- Ted
next prev parent reply other threads:[~2014-09-18 21:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-18 20:26 [PATCH 1/3] ext4: fold ext4_sync_fs_nojournal() into ext4_sync_fs() Theodore Ts'o
2014-09-18 20:26 ` [PATCH 2/3] ext4: support freezing ext2 (nojournal) file systems Theodore Ts'o
2014-09-18 20:46 ` Andreas Dilger
2014-09-18 21:13 ` Theodore Ts'o [this message]
2014-09-23 12:33 ` Jan Kara
2014-09-18 20:26 ` [PATCH 3/3] ext4: fold ext4_nojournal_sops into ext4_sops Theodore Ts'o
2014-09-23 12:31 ` Jan Kara
2014-09-23 12:29 ` [PATCH 1/3] ext4: fold ext4_sync_fs_nojournal() into ext4_sync_fs() Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140918211325.GC26995@thunk.org \
--to=tytso@mit.edu \
--cc=adilger@dilger.ca \
--cc=decui@microsoft.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).