From: Jan Kara <jack@suse.cz>
To: Tommy Kurby <tommykurby91@gmail.com>
Cc: jack@suse.cz, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fs: Ext2: xip.h: fixed coding style issues
Date: Tue, 23 Sep 2014 17:18:55 +0200 [thread overview]
Message-ID: <20140923151855.GA18189@quack.suse.cz> (raw)
In-Reply-To: <1411429600-4148-1-git-send-email-tommykurby91@gmail.com>
On Tue 23-09-14 01:46:40, Tommy Kurby wrote:
> Fixed coding style issues.
>
> Signed-off-by: Tommy Kurby <tommykurby91@gmail.com>
Hum, I think Matthew Wilcox's patches change this area as well and they
actually also do something useful. So I prefer not to merge this trivial
cleanup to not make Matthew's life unnecesarily harder.
Honza
> ---
> fs/ext2/xip.h | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/fs/ext2/xip.h b/fs/ext2/xip.h
> index 18b34d2..57b479b 100644
> --- a/fs/ext2/xip.h
> +++ b/fs/ext2/xip.h
> @@ -6,12 +6,13 @@
> */
>
> #ifdef CONFIG_EXT2_FS_XIP
> -extern void ext2_xip_verify_sb (struct super_block *);
> -extern int ext2_clear_xip_target (struct inode *, sector_t);
> +extern void ext2_xip_verify_sb(struct super_block *);
> +extern int ext2_clear_xip_target(struct inode *, sector_t);
>
> -static inline int ext2_use_xip (struct super_block *sb)
> +static inline int ext2_use_xip(struct super_block *sb)
> {
> struct ext2_sb_info *sbi = EXT2_SB(sb);
> +
> return (sbi->s_mount_opt & EXT2_MOUNT_XIP);
> }
> int ext2_get_xip_mem(struct address_space *, pgoff_t, int,
> --
> 2.1.0
>
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
prev parent reply other threads:[~2014-09-23 15:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-22 23:46 [PATCH] Fs: Ext2: xip.h: fixed coding style issues Tommy Kurby
2014-09-23 15:18 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140923151855.GA18189@quack.suse.cz \
--to=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tommykurby91@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).