* [PATCH] Fs: Ext2: xip.h: fixed coding style issues
@ 2014-09-22 23:46 Tommy Kurby
2014-09-23 15:18 ` Jan Kara
0 siblings, 1 reply; 2+ messages in thread
From: Tommy Kurby @ 2014-09-22 23:46 UTC (permalink / raw)
To: jack; +Cc: linux-ext4, linux-kernel, Tommy Kurby
Fixed coding style issues.
Signed-off-by: Tommy Kurby <tommykurby91@gmail.com>
---
fs/ext2/xip.h | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/fs/ext2/xip.h b/fs/ext2/xip.h
index 18b34d2..57b479b 100644
--- a/fs/ext2/xip.h
+++ b/fs/ext2/xip.h
@@ -6,12 +6,13 @@
*/
#ifdef CONFIG_EXT2_FS_XIP
-extern void ext2_xip_verify_sb (struct super_block *);
-extern int ext2_clear_xip_target (struct inode *, sector_t);
+extern void ext2_xip_verify_sb(struct super_block *);
+extern int ext2_clear_xip_target(struct inode *, sector_t);
-static inline int ext2_use_xip (struct super_block *sb)
+static inline int ext2_use_xip(struct super_block *sb)
{
struct ext2_sb_info *sbi = EXT2_SB(sb);
+
return (sbi->s_mount_opt & EXT2_MOUNT_XIP);
}
int ext2_get_xip_mem(struct address_space *, pgoff_t, int,
--
2.1.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Fs: Ext2: xip.h: fixed coding style issues
2014-09-22 23:46 [PATCH] Fs: Ext2: xip.h: fixed coding style issues Tommy Kurby
@ 2014-09-23 15:18 ` Jan Kara
0 siblings, 0 replies; 2+ messages in thread
From: Jan Kara @ 2014-09-23 15:18 UTC (permalink / raw)
To: Tommy Kurby; +Cc: jack, linux-ext4, linux-kernel
On Tue 23-09-14 01:46:40, Tommy Kurby wrote:
> Fixed coding style issues.
>
> Signed-off-by: Tommy Kurby <tommykurby91@gmail.com>
Hum, I think Matthew Wilcox's patches change this area as well and they
actually also do something useful. So I prefer not to merge this trivial
cleanup to not make Matthew's life unnecesarily harder.
Honza
> ---
> fs/ext2/xip.h | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/fs/ext2/xip.h b/fs/ext2/xip.h
> index 18b34d2..57b479b 100644
> --- a/fs/ext2/xip.h
> +++ b/fs/ext2/xip.h
> @@ -6,12 +6,13 @@
> */
>
> #ifdef CONFIG_EXT2_FS_XIP
> -extern void ext2_xip_verify_sb (struct super_block *);
> -extern int ext2_clear_xip_target (struct inode *, sector_t);
> +extern void ext2_xip_verify_sb(struct super_block *);
> +extern int ext2_clear_xip_target(struct inode *, sector_t);
>
> -static inline int ext2_use_xip (struct super_block *sb)
> +static inline int ext2_use_xip(struct super_block *sb)
> {
> struct ext2_sb_info *sbi = EXT2_SB(sb);
> +
> return (sbi->s_mount_opt & EXT2_MOUNT_XIP);
> }
> int ext2_get_xip_mem(struct address_space *, pgoff_t, int,
> --
> 2.1.0
>
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-09-23 15:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-22 23:46 [PATCH] Fs: Ext2: xip.h: fixed coding style issues Tommy Kurby
2014-09-23 15:18 ` Jan Kara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).