From: Christoph Hellwig <hch@infradead.org>
To: Jan Kara <jack@suse.cz>
Cc: Li Xi <pkuelelixi@gmail.com>,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-api@vger.kernel.org, tytso@mit.edu, adilger@dilger.ca,
viro@zeniv.linux.org.uk, hch@infradead.org, dmonakhov@openvz.org,
xfs@oss.sgi.com
Subject: Re: [PATCH 4/4] Adds ioctl interface support for ext4 project
Date: Wed, 24 Sep 2014 09:26:34 -0700 [thread overview]
Message-ID: <20140924162634.GA16886@infradead.org> (raw)
In-Reply-To: <20140924162507.GC27000@quack.suse.cz>
On Wed, Sep 24, 2014 at 06:25:07PM +0200, Jan Kara wrote:
> On Wed 24-09-14 22:04:30, Li Xi wrote:
> > This patch adds ioctl interface for setting/getting project of ext4.
> The patch looks good to me. I was just wondering whether it won't be
> useful to add an ioctl() which isn't ext4 specific. We could just extend
> ->setattr() to allow setting of project ID (most filesystems would just
> return -EOPNOTSUPP but ext4 and xfs could do the right thing) and then call
> ->setattr from the generic ioctl. That way userspace won't have to care
> about filesystem type when setting project ID... What do others think?
Absolutely. In general I also wonder why this patch doesn't implement
the full XFS API. Maybe there is a reason it was considered and
rejected, but it would be helpful to document why.
next prev parent reply other threads:[~2014-09-24 16:26 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-24 14:04 [PATCH 0/4] quota: add project quota support Li Xi
2014-09-24 14:04 ` [PATCH 1/4] Adds general codes to enforces project quota limits Li Xi
2014-09-24 16:08 ` Jan Kara
[not found] ` <1411567470-31799-2-git-send-email-lixi-LfVdkaOWEx8@public.gmane.org>
2014-09-24 16:14 ` Christoph Hellwig
[not found] ` <20140924161417.GA1978-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2014-09-24 17:10 ` Jan Kara
[not found] ` <20140924171020.GF27000-+0h/O2h83AeN3ZZ/Hiejyg@public.gmane.org>
2014-09-24 17:13 ` Christoph Hellwig
[not found] ` <20140924171306.GA23874-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2014-09-24 17:37 ` Jan Kara
2014-09-30 20:07 ` Jan Kara
2014-09-24 14:04 ` [PATCH 2/4] Adds project ID support for ext4 Li Xi
2014-09-24 17:11 ` Jan Kara
2014-09-25 1:09 ` Li Xi
2014-09-24 14:04 ` [PATCH 3/4] Adds project quota " Li Xi
[not found] ` <1411567470-31799-4-git-send-email-lixi-LfVdkaOWEx8@public.gmane.org>
2014-09-24 17:31 ` Jan Kara
[not found] ` <20140924173123.GH27000-+0h/O2h83AeN3ZZ/Hiejyg@public.gmane.org>
2014-09-25 1:28 ` Li Xi
[not found] ` <CAPTn0cB8X3DYprX-oKCu8aV5OLLfJJ2rh9YvMY7re69gi1s-LA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-09-25 11:55 ` Jan Kara
2014-09-24 14:04 ` [PATCH 4/4] Adds ioctl interface support for ext4 project Li Xi
2014-09-24 16:25 ` Jan Kara
2014-09-24 16:26 ` Christoph Hellwig [this message]
2014-09-24 17:01 ` Jan Kara
2014-09-25 7:59 ` Dave Chinner
2014-09-25 11:34 ` lixi
[not found] ` <C31A739F-4502-4B40-9AE3-F2FE49291657-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-09-26 0:10 ` Dave Chinner
2014-09-26 2:45 ` Li Xi
2014-09-25 13:41 ` Theodore Ts'o
[not found] ` <20140925134136.GE4592-AKGzg7BKzIDYtjvyW6yDsg@public.gmane.org>
2014-09-25 22:22 ` Dave Chinner
2014-09-25 13:52 ` Jan Kara
2014-09-25 22:42 ` Dave Chinner
2014-09-26 12:01 ` Theodore Ts'o
2014-09-29 15:55 ` Jan Kara
2014-09-25 7:26 ` Dave Chinner
[not found] ` <1411567470-31799-5-git-send-email-lixi-LfVdkaOWEx8@public.gmane.org>
2014-09-24 16:43 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140924162634.GA16886@infradead.org \
--to=hch@infradead.org \
--cc=adilger@dilger.ca \
--cc=dmonakhov@openvz.org \
--cc=jack@suse.cz \
--cc=linux-api@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=pkuelelixi@gmail.com \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).