From: Eric Whitney <enwlinux@gmail.com>
To: linux-ext4@vger.kernel.org
Cc: tytso@mit.edu
Subject: [PATCH] xfstests-bld: specify inode size in inline test scenario conf
Date: Fri, 26 Sep 2014 18:16:46 -0400 [thread overview]
Message-ID: <20140926221646.GA20955@wallace> (raw)
Some xfstests use test file systems that are smaller than 512 MB, and
per the mke2fs.conf default, contain 128 byte inodes. These tests
include xfstests generic/015, generic/077, generic/083, and shared/298.
All of them fail at mkfs time when run in xfstest-bld's inline test
scenario because the inline data feature requires a minimum inode size
of 256 bytes.
Fix this problem by specifying an inode size of 256 bytes in the inline
conf file. This allows the tester more flexibility than modifying the
xfstests themselves.
This change also makes it possible to run generic/027 successfully and
in a reasonable amount of time (less than 20 minutes on one x86-64 VM).
It also fails silently when mkfs'ing its test file system, but then
proceeds to run and reports success erroneously.
Signed-off-by: Eric Whitney <enwlinux@gmail.com>
---
kvm-xfstests/test-appliance/files/root/conf/inline | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kvm-xfstests/test-appliance/files/root/conf/inline b/kvm-xfstests/test-appliance/files/root/conf/inline
index 52b0609..9ba088f 100644
--- a/kvm-xfstests/test-appliance/files/root/conf/inline
+++ b/kvm-xfstests/test-appliance/files/root/conf/inline
@@ -1,7 +1,7 @@
export FS=ext4
export TEST_DEV=$VDD
export TEST_DIR=/vdd
-export MKFS_OPTIONS="-q -O inline_data,metadata_csum,64bit"
+export MKFS_OPTIONS="-q -I 256 -O inline_data,metadata_csum,64bit"
export EXT_MOUNT_OPTIONS="-o block_validity"
TESTNAME="Ext4 4k block w/inline"
--
1.9.1
next reply other threads:[~2014-09-26 22:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-26 22:16 Eric Whitney [this message]
2014-09-27 18:10 ` [PATCH] xfstests-bld: specify inode size in inline test scenario conf Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140926221646.GA20955@wallace \
--to=enwlinux@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox