From: Eric Whitney <enwlinux@gmail.com>
To: linux-ext4@vger.kernel.org
Cc: tytso@mit.edu
Subject: [PATCH] mke2fs: clarify inline data inode size error message
Date: Sat, 27 Sep 2014 11:55:15 -0400 [thread overview]
Message-ID: <20140927155515.GA2322@wallace> (raw)
The existing error message can be made more helpful by more clearly
implying the attempt to make a file system with undersized inodes is
failing and suggesting a corrective action.
Signed-off-by: Eric Whitney <enwlinux@gmail.com>
---
misc/mke2fs.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/misc/mke2fs.c b/misc/mke2fs.c
index 2bc435b..00bb00d 100644
--- a/misc/mke2fs.c
+++ b/misc/mke2fs.c
@@ -2358,7 +2358,8 @@ profile_error:
EXT4_FEATURE_INCOMPAT_INLINE_DATA) &&
fs_param.s_inode_size == EXT2_GOOD_OLD_INODE_SIZE) {
com_err(program_name, 0,
- _("inode size is %d, inline data is useless"),
+ _("%d byte inodes are too small for inline data; "
+ "specify larger size"),
fs_param.s_inode_size);
exit(1);
}
--
1.9.1
next reply other threads:[~2014-09-27 15:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-27 15:55 Eric Whitney [this message]
2014-09-29 5:53 ` [PATCH] mke2fs: clarify inline data inode size error message Darrick J. Wong
2014-10-01 20:36 ` Eric Whitney
2014-10-01 12:38 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140927155515.GA2322@wallace \
--to=enwlinux@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).