[PATCH] xfstests-bld: specify inode size in inline test scenario conf

[PATCH] xfstests-bld: specify inode size in inline test scenario conf

[Eric Whitney]

Some xfstests use test file systems that are smaller than 512 MB, and
per the mke2fs.conf default, contain 128 byte inodes.  These tests
include xfstests generic/015, generic/077, generic/083, and shared/298.
All of them fail at mkfs time when run in xfstest-bld's inline test
scenario because the inline data feature requires a minimum inode size
of 256 bytes.

Fix this problem by specifying an inode size of 256 bytes in the inline
conf file.  This allows the tester more flexibility than modifying the
xfstests themselves.

This change also makes it possible to run generic/027 successfully and
in a reasonable amount of time (less than 20 minutes on one x86-64 VM).
It also fails silently when mkfs'ing its test file system, but then
proceeds to run and reports success erroneously.

Signed-off-by: Eric Whitney <enwlinux@gmail.com>
---
 kvm-xfstests/test-appliance/files/root/conf/inline | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kvm-xfstests/test-appliance/files/root/conf/inline b/kvm-xfstests/test-appliance/files/root/conf/inline
index 52b0609..9ba088f 100644
--- a/kvm-xfstests/test-appliance/files/root/conf/inline
+++ b/kvm-xfstests/test-appliance/files/root/conf/inline
@@ -1,7 +1,7 @@
 export FS=ext4
 export TEST_DEV=$VDD
 export TEST_DIR=/vdd
-export MKFS_OPTIONS="-q -O inline_data,metadata_csum,64bit"
+export MKFS_OPTIONS="-q -I 256 -O inline_data,metadata_csum,64bit"
 export EXT_MOUNT_OPTIONS="-o block_validity"
 TESTNAME="Ext4 4k block w/inline"
 
-- 
1.9.1

Re: [PATCH] xfstests-bld: specify inode size in inline test scenario conf

[Theodore Ts'o]

On Fri, Sep 26, 2014 at 06:16:46PM -0400, Eric Whitney wrote:
> Some xfstests use test file systems that are smaller than 512 MB, and
> per the mke2fs.conf default, contain 128 byte inodes.  These tests
> include xfstests generic/015, generic/077, generic/083, and shared/298.
> All of them fail at mkfs time when run in xfstest-bld's inline test
> scenario because the inline data feature requires a minimum inode size
> of 256 bytes.
> 
> Fix this problem by specifying an inode size of 256 bytes in the inline
> conf file.  This allows the tester more flexibility than modifying the
> xfstests themselves.
> 
> This change also makes it possible to run generic/027 successfully and
> in a reasonable amount of time (less than 20 minutes on one x86-64 VM).
> It also fails silently when mkfs'ing its test file system, but then
> proceeds to run and reports success erroneously.
> 
> Signed-off-by: Eric Whitney <enwlinux@gmail.com>

Applied, thanks.

						- Ted