* [PATCH] generic/226: improve mkfs and mount error handling
@ 2014-10-02 20:34 Eric Whitney
0 siblings, 0 replies; only message in thread
From: Eric Whitney @ 2014-10-02 20:34 UTC (permalink / raw)
To: fstests; +Cc: linux-ext4
If 226's attempt to make a scratch device fails, it can inadvertently
mount and run on a pre-existing scratch file system. This can lead to
invalid test results unless the mkfs failure is separately noted in
226.full.
Noted while debugging an ext4 inline data test failure. Small ext4 file
systems, as used by this test, use small inodes that are incompatible
with inline data.
Signed-off-by: Eric Whitney <enwlinux@gmail.com>
---
tests/generic/226 | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/tests/generic/226 b/tests/generic/226
index b98e889..44b60ff 100755
--- a/tests/generic/226
+++ b/tests/generic/226
@@ -43,8 +43,9 @@ rm -f $seqres.full
umount $SCRATCH_DEV 2>/dev/null
echo "--> mkfs 256m filesystem"
-_scratch_mkfs_sized `expr 256 \* 1024 \* 1024` >> $seqres.full 2>&1
-_scratch_mount
+_scratch_mkfs_sized `expr 256 \* 1024 \* 1024` >> $seqres.full 2>&1 \
+ || _fail "mkfs failed"
+_scratch_mount >> $seqres.full 2>&1 || _fail "mount failed"
loops=16
--
1.9.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2014-10-02 20:34 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-02 20:34 [PATCH] generic/226: improve mkfs and mount error handling Eric Whitney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).