From: Theodore Ts'o <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: Bail early when clearing inode journal flag fails
Date: Thu, 30 Oct 2014 10:36:56 -0400 [thread overview]
Message-ID: <20141030143656.GB31927@thunk.org> (raw)
In-Reply-To: <1414069543-29853-1-git-send-email-jack@suse.cz>
On Thu, Oct 23, 2014 at 03:05:43PM +0200, Jan Kara wrote:
> When clearing inode journal flag, we call jbd2_journal_flush() to force
> all the journalled data to their final locations. Currently we ignore
> when this fails and continue clearing inode journal flag. This isn't a
> big problem because when jbd2_journal_flush() fails, journal is likely
> aborted anyway. But it can still lead to somewhat confusing results so
> rather bail out early.
>
> Coverity-id: 989044
> Signed-off-by: Jan Kara <jack@suse.cz>
Applied, thanks.
- Ted
prev parent reply other threads:[~2014-10-30 14:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-23 13:05 [PATCH] ext4: Bail early when clearing inode journal flag fails Jan Kara
2014-10-30 14:36 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141030143656.GB31927@thunk.org \
--to=tytso@mit.edu \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).