From: Theodore Ts'o <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: Make ext4_ext_convert_to_initialized() return proper number of blocks
Date: Thu, 30 Oct 2014 10:45:34 -0400 [thread overview]
Message-ID: <20141030144534.GC31927@thunk.org> (raw)
In-Reply-To: <1413966550-27404-1-git-send-email-jack@suse.cz>
On Wed, Oct 22, 2014 at 10:29:10AM +0200, Jan Kara wrote:
> ext4_ext_convert_to_initialized() can return more blocks than are
> actually allocated from map->m_lblk in case where initial part of the
> on-disk extent is zeroed out. Luckily this doesn't have serious
> consequences because the caller currently uses the return value
> only to unmap metadata buffers. Anyway this is a data
> corruption/exposure problem waiting to happen so fix it.
>
> Coverity-id: 1226848
> Signed-off-by: Jan Kara <jack@suse.cz>
Applied, thanks.
- Ted
prev parent reply other threads:[~2014-10-30 14:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-22 8:29 [PATCH] ext4: Make ext4_ext_convert_to_initialized() return proper number of blocks Jan Kara
2014-10-30 14:45 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141030144534.GC31927@thunk.org \
--to=tytso@mit.edu \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).