From: Eric Whitney <enwlinux@gmail.com>
To: Theodore Ts'o <tytso@mit.edu>
Cc: Eric Whitney <enwlinux@gmail.com>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH 4/4] ext4: fix end of region partial cluster handling
Date: Sun, 23 Nov 2014 12:05:08 -0500 [thread overview]
Message-ID: <20141123170508.GA2813@wallace> (raw)
In-Reply-To: <20141123060517.GC4102@thunk.org>
The retry occurs at the end of ext4_ext_remove_space where the code loops
back to the top of the function if err == -EAGAIN, leading to another call
to ext4_ext_rm_leaf. Nothing new needs to be added - we simply want to
avoid using invalid state to decide whether to free a partial cluster (on
occurrence of -EAGAIN), and the existing retry loop will eventually get us
valid state.
(I actually saw this in testing, but it takes a lot of runs to get there.)
Sorry if I edited down my comment a little too far - I'd be happy to beef
that up if desired.
Thanks,
Eric
* Theodore Ts'o <tytso@mit.edu>:
> On Fri, Nov 21, 2014 at 09:59:04AM -0500, Eric Whitney wrote:
> > ext4_ext_remove_space() can incorrectly free a partial_cluster if
> > EAGAIN is encountered while truncating or punching. Extent removal
> > should be retried in this case.
>
> I don't see anything in the patch below which retries the extent
> removal; am I missing something?
>
> Thanks,
>
> - Ted
prev parent reply other threads:[~2014-11-23 17:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-21 14:59 [PATCH 4/4] ext4: fix end of region partial cluster handling Eric Whitney
2014-11-23 6:05 ` Theodore Ts'o
2014-11-23 17:05 ` Eric Whitney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141123170508.GA2813@wallace \
--to=enwlinux@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).