From: Theodore Ts'o <tytso@mit.edu>
To: Dmitry Monakhov <dmonakhov@openvz.org>
Cc: linux-ext4@vger.kernel.org, cmm@us.ibm.com
Subject: Re: [PATCH 1/2] ext4: cleanup GFP flags inside resize path V2
Date: Tue, 25 Nov 2014 13:08:36 -0500 [thread overview]
Message-ID: <20141125180836.GD11648@thunk.org> (raw)
In-Reply-To: <1415958040-4393-1-git-send-email-dmonakhov@openvz.org>
On Fri, Nov 14, 2014 at 01:40:39PM +0400, Dmitry Monakhov wrote:
> We must use GFP_NOFS instead GFP_KERNEL inside ext4_mb_add_groupinfo because resize-path
> call it inside journal transaction. Call trace:
> ioctl
> ->ext4_group_add
> ->journal_start
> ->ext4_setup_new_descs
> ->ext4_mb_add_groupinfo -> GFP_KERNEL
> ->ext4_flex_group_add
> ->ext4_update_super
> ->ext4_calculate_overhead -> GFP_KERNEL
> ->journal_stop
>
> Changes from V1:
> - Fix up gfp flags for ext4_calculate_overhead
>
> ext4_update_super
>
> Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
Applied, thanks, with a slightly cleaned up commit description.
- Ted
prev parent reply other threads:[~2014-11-25 18:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-14 9:40 [PATCH 1/2] ext4: cleanup GFP flags inside resize path V2 Dmitry Monakhov
2014-11-14 9:40 ` [PATCH 2/2] ext4: fix potential use after free issue while fsresize Dmitry Monakhov
2014-11-25 18:27 ` Theodore Ts'o
2014-11-27 13:06 ` Dmitry Monakhov
2014-11-24 12:55 ` [PATCH 1/2] ext4: cleanup GFP flags inside resize path V2 Dmitry Monakhov
2014-11-25 18:08 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141125180836.GD11648@thunk.org \
--to=tytso@mit.edu \
--cc=cmm@us.ibm.com \
--cc=dmonakhov@openvz.org \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).