From: Theodore Ts'o <tytso@mit.edu>
To: Eric Sandeen <sandeen@redhat.com>
Cc: ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] ext4: don't count external journal blocks as overhead
Date: Tue, 25 Nov 2014 16:33:02 -0500 [thread overview]
Message-ID: <20141125213302.GF28449@thunk.org> (raw)
In-Reply-To: <54664C73.60409@redhat.com>
On Fri, Nov 14, 2014 at 12:39:47PM -0600, Eric Sandeen wrote:
> This was fixed for ext3 with:
>
> e6d8fb3 ext3: Count internal journal as bsddf overhead in ext3_statfs
>
> but was never fixed for ext4.
>
> With a large external journal and no used disk blocks, df comes
> out negative without this, as journal blocks are added to the
> overhead & subtracted from used blocks unconditionally.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Thanks, applied.
- Ted
prev parent reply other threads:[~2014-11-25 21:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-14 18:39 [PATCH] ext4: don't count external journal blocks as overhead Eric Sandeen
2014-11-25 21:33 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141125213302.GF28449@thunk.org \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).