* [PATCH] ext4: fix sparse warnings with new shash api usage
@ 2014-11-26 23:51 Darrick J. Wong
2014-11-27 5:32 ` Theodore Ts'o
0 siblings, 1 reply; 2+ messages in thread
From: Darrick J. Wong @ 2014-11-26 23:51 UTC (permalink / raw)
To: Ted Tso; +Cc: linux-ext4
Use __le32, not u32 so that sparse is happy.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
fs/ext4/ext4.h | 6 +++---
include/linux/jbd2.h | 6 +++---
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
index 93e0efe..da83f20 100644
--- a/fs/ext4/ext4.h
+++ b/fs/ext4/ext4.h
@@ -1784,15 +1784,15 @@ static inline u32 ext4_chksum(struct ext4_sb_info *sbi, u32 crc,
struct shash_desc shash;
char ctx[4];
} desc;
- u32 out_crc;
+ __le32 out_crc;
int err;
BUG_ON(crypto_shash_descsize(sbi->s_chksum_driver)!=sizeof(desc.ctx));
desc.shash.tfm = sbi->s_chksum_driver;
desc.shash.flags = 0;
- crc = cpu_to_le32(crc);
- crypto_shash_setkey(desc.shash.tfm, (u8 *)&crc, sizeof(crc));
+ out_crc = cpu_to_le32(crc);
+ crypto_shash_setkey(desc.shash.tfm, (u8 *)&out_crc, sizeof(out_crc));
crypto_shash_init(&desc.shash);
err = crypto_shash_update(&desc.shash, address, length);
diff --git a/include/linux/jbd2.h b/include/linux/jbd2.h
index 8ce1196..ae365ca 100644
--- a/include/linux/jbd2.h
+++ b/include/linux/jbd2.h
@@ -1374,7 +1374,7 @@ static inline u32 jbd2_chksum(journal_t *journal, u32 crc,
struct shash_desc shash;
char ctx[JBD_MAX_CHECKSUM_SIZE];
} desc;
- u32 out_crc;
+ __le32 out_crc;
int err;
BUG_ON(crypto_shash_descsize(journal->j_chksum_driver) >
@@ -1382,8 +1382,8 @@ static inline u32 jbd2_chksum(journal_t *journal, u32 crc,
desc.shash.tfm = journal->j_chksum_driver;
desc.shash.flags = 0;
- crc = cpu_to_le32(crc);
- crypto_shash_setkey(desc.shash.tfm, (u8 *)&crc, sizeof(crc));
+ out_crc = cpu_to_le32(crc);
+ crypto_shash_setkey(desc.shash.tfm, (u8 *)&out_crc, sizeof(out_crc));
crypto_shash_init(&desc.shash);
err = crypto_shash_update(&desc.shash, address, length);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ext4: fix sparse warnings with new shash api usage
2014-11-26 23:51 [PATCH] ext4: fix sparse warnings with new shash api usage Darrick J. Wong
@ 2014-11-27 5:32 ` Theodore Ts'o
0 siblings, 0 replies; 2+ messages in thread
From: Theodore Ts'o @ 2014-11-27 5:32 UTC (permalink / raw)
To: Darrick J. Wong; +Cc: linux-ext4
On Wed, Nov 26, 2014 at 03:51:09PM -0800, Darrick J. Wong wrote:
> Use __le32, not u32 so that sparse is happy.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Thanks, I'll fold this into the shash api patch.
- Ted
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-11-27 5:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-26 23:51 [PATCH] ext4: fix sparse warnings with new shash api usage Darrick J. Wong
2014-11-27 5:32 ` Theodore Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).