From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: "Theodore Ts'o" <tytso@mit.edu>
Cc: linux-ext4@vger.kernel.org, Eric Whitney <enwlinux@gmail.com>
Subject: Re: xfstests failures w/ metadata_csum
Date: Mon, 1 Dec 2014 14:02:09 -0800 [thread overview]
Message-ID: <20141201220209.GS10043@birch.djwong.org> (raw)
In-Reply-To: <20141201202045.GR10043@birch.djwong.org>
CRAP.
The real cause of the regression that Eric reported is: The first time we
enable journal_checksum on a journal, we fail to set the checksum seed because
the seed calculation is gated on jbd2_journal_has_csum_v2or3() ... before we
actually set the superblock feature fields! Yikes!
The fix is to get rid of the braindead check and always calculate the seed.
I will have a regression fix for 3.18-rc7 out shortly.
(I'll also post a patch to complain loudly, but that isn't critical.)
--D
On Mon, Dec 01, 2014 at 12:20:45PM -0800, Darrick J. Wong wrote:
> Hi Eric,
>
> Could you remind me which xfstests are failing in 3.18-rc3+ with metadata_csum
> enabled? I think you said generic/034, generic/321, and generic/322, but were
> there more?
>
> AFAICT the ext4 mount fails because it can't load the journal, and the journal
> can't replay because jbd2_descr_block_csum_verify() fails; the 034 test appears
> to drop all the writes related to the umount. recovery.c doesn't say anything
> when the journal descriptor block fails csum verification, though it should.
> Not sure why we end up with corrupt-looking descriptor blocks.
>
> The reason why this appears in -rc3 is because that's when we added the patch
> that forces journal_checksum on whenever metadata_csum is on, and I guess
> few people were testing journal_checksum with xfstests before that.
>
> --D
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-12-01 22:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-01 20:20 xfstests failures w/ metadata_csum Darrick J. Wong
2014-12-01 22:02 ` Darrick J. Wong [this message]
2014-12-01 22:05 ` Eric Whitney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141201220209.GS10043@birch.djwong.org \
--to=darrick.wong@oracle.com \
--cc=enwlinux@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).