linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: tytso@mit.edu
Cc: linux-ext4@vger.kernel.org
Subject: [PATCH 50/47] e2fsck: remove 'invalid' wording from error when extent block fails checksum
Date: Tue, 2 Dec 2014 18:52:51 -0800	[thread overview]
Message-ID: <20141203025251.GA10059@birch.djwong.org> (raw)

Don't say the physical block number is invalid if an extent block
fails only the checksum.  It passes checks, so it's not invalid.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
 e2fsck/problem.c                      |    2 +-
 tests/f_extent_int_bad_csum/expect.1  |    2 +-
 tests/f_extent_leaf_bad_csum/expect.1 |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/e2fsck/problem.c b/e2fsck/problem.c
index 75e0305..b1bcc0d 100644
--- a/e2fsck/problem.c
+++ b/e2fsck/problem.c
@@ -998,7 +998,7 @@ static struct e2fsck_problem problem_table[] = {
 	 */
 	{ PR_1_EXTENT_ONLY_CSUM_INVALID,
 	  N_("@i %i extent block passes checks, but checksum does not match "
-	     "extent\n\t(logical @b %c, @n physical @b %b, len %N)\n"),
+	     "extent\n\t(logical @b %c, physical @b %b, len %N)\n"),
 	  PROMPT_FIX, 0 },
 
 	/*
diff --git a/tests/f_extent_int_bad_csum/expect.1 b/tests/f_extent_int_bad_csum/expect.1
index 57a2a61..7b412b8 100644
--- a/tests/f_extent_int_bad_csum/expect.1
+++ b/tests/f_extent_int_bad_csum/expect.1
@@ -1,6 +1,6 @@
 Pass 1: Checking inodes, blocks, and sizes
 Inode 12 extent block passes checks, but checksum does not match extent
-	(logical block 698, invalid physical block 1788, len 1)
+	(logical block 698, physical block 1788, len 1)
 Fix? yes
 
 Pass 2: Checking directory structure
diff --git a/tests/f_extent_leaf_bad_csum/expect.1 b/tests/f_extent_leaf_bad_csum/expect.1
index 0dc78ad..86e501a 100644
--- a/tests/f_extent_leaf_bad_csum/expect.1
+++ b/tests/f_extent_leaf_bad_csum/expect.1
@@ -1,6 +1,6 @@
 Pass 1: Checking inodes, blocks, and sizes
 Inode 12 extent block passes checks, but checksum does not match extent
-	(logical block 7, invalid physical block 1090, len 1)
+	(logical block 7, physical block 1090, len 1)
 Fix? yes
 
 Pass 2: Checking directory structure

                 reply	other threads:[~2014-12-03  2:52 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141203025251.GA10059@birch.djwong.org \
    --to=darrick.wong@oracle.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).