* [ext4:crypto 8/21] fs/ext4/xattr_encryption.c:80:5: sparse: symbol 'ext4_xattr_encryption_context_set' was not declared. Should it be static?
@ 2015-01-16 2:07 kbuild test robot
2015-01-16 2:07 ` [PATCH ext4] ext4 crypto: ext4_xattr_encryption_context_set() can be static kbuild test robot
0 siblings, 1 reply; 2+ messages in thread
From: kbuild test robot @ 2015-01-16 2:07 UTC (permalink / raw)
To: Michael Halcrow
Cc: kbuild-all, Theodore Ts'o, Andreas Dilger, linux-ext4,
linux-kernel
tree: git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git crypto
head: e32261a72a3c0c6c59d761820d8ca8b7c90008af
commit: db813a4cea85922497d58e94304d75517576af03 [8/21] ext4 crypto: add encryption xattr support
reproduce:
# apt-get install sparse
git checkout db813a4cea85922497d58e94304d75517576af03
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by >>)
>> fs/ext4/xattr_encryption.c:80:5: sparse: symbol 'ext4_xattr_encryption_context_set' was not declared. Should it be static?
Please review and possibly fold the followup patch.
---
0-DAY kernel test infrastructure Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
^ permalink raw reply [flat|nested] 2+ messages in thread* [PATCH ext4] ext4 crypto: ext4_xattr_encryption_context_set() can be static 2015-01-16 2:07 [ext4:crypto 8/21] fs/ext4/xattr_encryption.c:80:5: sparse: symbol 'ext4_xattr_encryption_context_set' was not declared. Should it be static? kbuild test robot @ 2015-01-16 2:07 ` kbuild test robot 0 siblings, 0 replies; 2+ messages in thread From: kbuild test robot @ 2015-01-16 2:07 UTC (permalink / raw) To: Michael Halcrow Cc: kbuild-all, Theodore Ts'o, Andreas Dilger, linux-ext4, linux-kernel fs/ext4/xattr_encryption.c:80:5: sparse: symbol 'ext4_xattr_encryption_context_set' was not declared. Should it be static? Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> --- xattr_encryption.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ext4/xattr_encryption.c b/fs/ext4/xattr_encryption.c index d03697a..851064a 100644 --- a/fs/ext4/xattr_encryption.c +++ b/fs/ext4/xattr_encryption.c @@ -77,7 +77,7 @@ static int ext4_xattr_encryption_set(struct dentry *dentry, const char *name, * Made as a separate function on purpose, so that setting this value from user * space tools is not available through generic set attribute path. */ -int ext4_xattr_encryption_context_set(struct dentry *dentry, const void *value, +static int ext4_xattr_encryption_context_set(struct dentry *dentry, const void *value, size_t size, int flags, int type) { return ext4_xattr_set(dentry->d_inode, ^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-01-16 2:07 UTC | newest] Thread overview: 2+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-01-16 2:07 [ext4:crypto 8/21] fs/ext4/xattr_encryption.c:80:5: sparse: symbol 'ext4_xattr_encryption_context_set' was not declared. Should it be static? kbuild test robot 2015-01-16 2:07 ` [PATCH ext4] ext4 crypto: ext4_xattr_encryption_context_set() can be static kbuild test robot
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).