From mboxrd@z Thu Jan 1 00:00:00 1970 From: kbuild test robot Subject: [PATCH ext4] ext4 crypto: ext4_fname_decrypt() can be static Date: Fri, 16 Jan 2015 10:27:32 +0800 Message-ID: <20150116022732.GA55041@snb> References: <201501161021.CZOoWii2%fengguang.wu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kbuild-all@01.org, Theodore Ts'o , Uday Savagaonkar , Ildar Muslukhov , Andreas Dilger , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org To: Michael Halcrow Return-path: Content-Disposition: inline In-Reply-To: <201501161021.CZOoWii2%fengguang.wu@intel.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-ext4.vger.kernel.org fs/ext4/crypto_fname.c:322:5: sparse: symbol 'ext4_fname_decrypt' was not declared. Should it be static? fs/ext4/crypto_fname.c:380:5: sparse: symbol 'ext4_fname_encode_digest' was not declared. Should it be static? fs/ext4/crypto_fname.c:479:6: sparse: symbol 'ext4_free_fname_crypto_ctx' was not declared. Should it be static? fs/ext4/crypto_fname.c:532:30: sparse: symbol 'ext4_alloc_fname_crypto_ctx' was not declared. Should it be static? Signed-off-by: Fengguang Wu --- crypto_fname.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/fs/ext4/crypto_fname.c b/fs/ext4/crypto_fname.c index e1a72d1..4b4b507 100644 --- a/fs/ext4/crypto_fname.c +++ b/fs/ext4/crypto_fname.c @@ -319,7 +319,7 @@ static int ext4_fname_encrypt(struct ext4_fname_crypto_ctx *ctx, * Errors are returned as negative numbers. * We trust the caller to allocate sufficient memory to oname string. */ -int ext4_fname_decrypt(struct ext4_fname_crypto_ctx *ctx, +static int ext4_fname_decrypt(struct ext4_fname_crypto_ctx *ctx, struct ext4_cstr *oname, const struct ext4_cstr *iname) { @@ -377,7 +377,7 @@ int ext4_fname_decrypt(struct ext4_fname_crypto_ctx *ctx, * Encodes the input digest using characters from the set [a-zA-Z0-9_+]. * The encoded string is roughly 4/3 times the size of the input string. */ -int ext4_fname_encode_digest(char *dst, char *src, u32 len) +static int ext4_fname_encode_digest(char *dst, char *src, u32 len) { static const char *lookup_table = "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789_+"; @@ -476,7 +476,7 @@ out: * * Frees up a crypto context. */ -void ext4_free_fname_crypto_ctx(struct ext4_fname_crypto_ctx *ctx) +static void ext4_free_fname_crypto_ctx(struct ext4_fname_crypto_ctx *ctx) { if (ctx == NULL || IS_ERR(ctx)) return; @@ -529,7 +529,7 @@ static struct ext4_fname_crypto_ctx *ext4_search_fname_crypto_ctx( /** * ext4_alloc_fname_crypto_ctx() - */ -struct ext4_fname_crypto_ctx *ext4_alloc_fname_crypto_ctx( +static struct ext4_fname_crypto_ctx *ext4_alloc_fname_crypto_ctx( const struct ext4_encryption_key *key) { struct ext4_fname_crypto_ctx *ctx;