Re: [PATCH] ext4: add regression tests for ^extents punch hole

Dave Chinner
2015-02-24T11:31:08Z

On Tue, Feb 24, 2015 at 11:11:04AM +0100, Lukáš Czerner wrote:
> On Tue, 24 Feb 2015, Dave Chinner wrote:
>
> > Date: Tue, 24 Feb 2015 09:46:20 +1100
> > From: Dave Chinner <david@fromorbit.com>
> > To: Omar Sandoval <osandov@osandov.com>
> > Cc: fstests@vger.kernel.org, linux-ext4@vger.kernel.org
> > Subject: Re: [PATCH] ext4: add regression tests for ^extents punch hole
> >
> > On Mon, Feb 23, 2015 at 02:39:36PM -0800, Omar Sandoval wrote:
> > > Linux commit 6f30b7e37a82 (ext4: fix indirect punch hole corruption)
> > > fixes several bugs in the FALLOC_FL_PUNCH_HOLE implementation for an
> > > ext4 filesystem with indirect blocks.
> > >
> > > Signed-off-by: Omar Sandoval <osandov@osandov.com>
> > > ---
> > > tests/ext4/005 | 115 +++++++++++++++++++++++++++++++++++++++++++++++++++++
> > > tests/ext4/005.out | 29 ++++++++++++++
> > > tests/ext4/group | 1 +
> > > 3 files changed, 145 insertions(+)
> > > create mode 100755 tests/ext4/005
> > > create mode 100644 tests/ext4/005.out
> >
> > What's ext4 specific about this test apart from the mkfs parameter?
> > Shouldn't it be generic and so test all the filesystems behave the
> > same? i.e. when someone then runs
> >
> > # MKFS_OPTIONS="-b size=1k -O ^extents" ./check -g auto
> >
> > That will exercise this specific regression fix, not to mention give
> > much, much better test coverage of that configuration than just
> > making a single test use that config...
> >
> > Cheers,
> >
> > Dave.
>
> Hi Dave,
>
> it's not that long ago when we discussed very similar case, where
> directly in the test itself the author would specify mkfs options. I
> had the same comment as you have here and you argued that the test
> was made specifically to test that mkfs option. I agree.

The case I remember and was basing this off was commit 448efe1
("generic/017: Do not create file systems with different block
sizes") where you made the argument that we shouldn't be setting
mkfs parameters inside the test and instead those specific cases
would be tested by using test-wide mkfs parameters....

I don't recall any other discussion, so maybe you should remind me
of it....

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com