From: Theodore Ts'o <tytso@mit.edu>
To: Dave Chinner <david@fromorbit.com>
Cc: "Lukáš Czerner" <lczerner@redhat.com>,
"Omar Sandoval" <osandov@osandov.com>,
fstests@vger.kernel.org, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: add regression tests for ^extents punch hole
Date: Tue, 24 Feb 2015 19:24:37 -0500 [thread overview]
Message-ID: <20150225002437.GB3782@thunk.org> (raw)
In-Reply-To: <20150224124938.GB4251@dastard>
On Tue, Feb 24, 2015 at 11:49:38PM +1100, Dave Chinner wrote:
>
> Ah, right, I said that was during the discussion about the commit I
> quoted above. You convinced me that we shouldn't cater for special
> cases like this and instead iterate mkfs/mount configurations.
I was in favor of iterating over mkfs/mount configurations myself --
and that's something I do, but it takes around 20 hours to run all of
the iterations, so it's not something I'm doing _all_ that often.
> I think the test should still be generic and block size independent,
> but if you want to force ext4 to turn off the extents flag, then
> use something like this:
I suspect our current generic fsstress and fsx tests would catch this
already, and what I need to do is to make sure I add ext3/1k to my
test configurations (currently I test an ext3 configuration, and a 1k
block configuration, but I don't currently test ext3/1k together).
That would probably round out my full test iteration to a very
pleasing 24 hours or so, which is fine, although I wouldn't want it to
take much longer than that.
> /me shakes his head, wonders how other maintainers stay sane
They're coming to take me away, ha-haaa.
They're coming to take me away, ho ho, he he , ha ha,
To the happy home with trees and flowers and chirping birds
And basket weavers who sit and smile
And twiddle their thumbs and toes
And they're coming to take me away, ha-haaa!
:-)
- Ted
next prev parent reply other threads:[~2015-02-25 0:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-23 22:39 [PATCH] ext4: add regression tests for ^extents punch hole Omar Sandoval
2015-02-23 22:46 ` Dave Chinner
2015-02-23 23:11 ` Omar Sandoval
2015-02-23 23:28 ` Eric Sandeen
2015-02-23 23:43 ` Eric Sandeen
2015-02-24 10:11 ` Lukáš Czerner
2015-02-24 11:31 ` Dave Chinner
2015-02-24 11:52 ` Lukáš Czerner
2015-02-24 12:49 ` Dave Chinner
2015-02-24 14:58 ` Lukáš Czerner
2015-02-24 22:07 ` Dave Chinner
2015-02-25 0:24 ` Theodore Ts'o [this message]
2015-02-25 3:03 ` Omar Sandoval
2015-02-25 8:42 ` Lukáš Czerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150225002437.GB3782@thunk.org \
--to=tytso@mit.edu \
--cc=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=osandov@osandov.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox