* [PATCH] ext4: fix comments in ext4_can_extents_be_merged()
@ 2015-02-04 11:11 Xiaoguang Wang
2015-04-02 20:55 ` Theodore Ts'o
0 siblings, 1 reply; 2+ messages in thread
From: Xiaoguang Wang @ 2015-02-04 11:11 UTC (permalink / raw)
To: linux-ext4; +Cc: tytso, darrick.wong, Xiaoguang Wang
Since commit 66369e0, we are allowed to merge unwritten extents,
so here these comments are wrong, remove it.
Signed-off-by: Xiaoguang Wang <wangxg.fnst@cn.fujitsu.com>
---
fs/ext4/extents.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index bed4308..2e6af88 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -1717,12 +1717,6 @@ ext4_can_extents_be_merged(struct inode *inode, struct ext4_extent *ex1,
{
unsigned short ext1_ee_len, ext2_ee_len;
- /*
- * Make sure that both extents are initialized. We don't merge
- * unwritten extents so that we can be sure that end_io code has
- * the extent that was written properly split out and conversion to
- * initialized is trivial.
- */
if (ext4_ext_is_unwritten(ex1) != ext4_ext_is_unwritten(ex2))
return 0;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ext4: fix comments in ext4_can_extents_be_merged()
2015-02-04 11:11 [PATCH] ext4: fix comments in ext4_can_extents_be_merged() Xiaoguang Wang
@ 2015-04-02 20:55 ` Theodore Ts'o
0 siblings, 0 replies; 2+ messages in thread
From: Theodore Ts'o @ 2015-04-02 20:55 UTC (permalink / raw)
To: Xiaoguang Wang; +Cc: linux-ext4, darrick.wong
On Wed, Feb 04, 2015 at 07:11:45PM +0800, Xiaoguang Wang wrote:
> Since commit 66369e0, we are allowed to merge unwritten extents,
> so here these comments are wrong, remove it.
>
> Signed-off-by: Xiaoguang Wang <wangxg.fnst@cn.fujitsu.com>
Thanks, applied.
BTW, the commit ID was wrong; I've corrected it to be a9b8241594add.
- Ted
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-04-02 20:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-04 11:11 [PATCH] ext4: fix comments in ext4_can_extents_be_merged() Xiaoguang Wang
2015-04-02 20:55 ` Theodore Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).