linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Theodore Ts'o <tytso@mit.edu>, linux-ext4@vger.kernel.org
Subject: Use of resize2fs for enabling 64-bit inodes
Date: Fri, 17 Apr 2015 18:18:09 +0200	[thread overview]
Message-ID: <20150417161809.GA27500@quack.suse.cz> (raw)

  Hello,

  I've noticed that you've implemented enabling 64-bit mode of a filesystem
in resize2fs. That is quite logical from the implementation point of view
however IMHO it doesn't make too much sense from user point of view.  I'd
rather expect that functionality to be in tune2fs. So shouldn't we rather
abstract the code into a separate library that would be linked to both
resize2fs and tune2fs? Alternatively we could just make tune2fs call
resize2fs with appropriate options.

I'm asking because I'm now looking into implementing increasing number of
reserved inodes. For that we may need to move some inodes and it would be
natural to use code from resize2fs for that. But adding that as an option
to resize2fs is just unintuitive from user point of view so I'd like to
have some concensus on how we do this... Darrick, Ted, any opinion?

								Honza

-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR

             reply	other threads:[~2015-04-17 16:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-17 16:18 Jan Kara [this message]
2015-04-17 18:58 ` Use of resize2fs for enabling 64-bit inodes Darrick J. Wong
2015-04-20 10:25   ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150417161809.GA27500@quack.suse.cz \
    --to=jack@suse.cz \
    --cc=darrick.wong@oracle.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).