From: Theodore Ts'o <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: linux-ext4@vger.kernel.org
Subject: Re: Coverity complaints about new crypto code
Date: Tue, 5 May 2015 08:41:06 -0400 [thread overview]
Message-ID: <20150505124106.GA11805@thunk.org> (raw)
In-Reply-To: <20150505075436.GA11943@quack.suse.cz>
On Tue, May 05, 2015 at 09:54:36AM +0200, Jan Kara wrote:
>
> Coverity complains about the new ext4 crypto code. The complaint is that
> ext4_fname_crypto_alloc_buffer() and ext4_fname_crypto_namelen_on_disk()
> check for ctx being NULL but they dereference it before that check.
> I've checked and didn't find callers that would actually pass NULL into
> these functions so do we want to remove the unused check or move the
> dereference? I think it would be worth cleaning up just that we don't fall
> into the trap sometime later...
I'm going to be posting a performance patch shortly that drops
ext4_fname_crypto_ctx entirely (and with it those checks, obviously).
So that should take care of that.
Cheers,
- Ted
prev parent reply other threads:[~2015-05-05 12:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-05 7:54 Coverity complaints about new crypto code Jan Kara
2015-05-05 12:41 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150505124106.GA11805@thunk.org \
--to=tytso@mit.edu \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).