From: Theodore Ts'o <tytso@mit.edu>
To: Mohamad Ayyash <mkayyash@google.com>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] ext4: don't save the error information if the block device is read-only
Date: Fri, 15 May 2015 19:36:17 -0400 [thread overview]
Message-ID: <20150515233617.GA4599@thunk.org> (raw)
In-Reply-To: <CAG_9a6cSd-1VDD8zkCt7zFPbBi01a78VeOTDyi0NJuvS26XApw@mail.gmail.com>
On Fri, May 15, 2015 at 09:34:18PM +0000, Mohamad Ayyash wrote:
> I wonder if there should be some similar protection at other callers of
> ext4_commit_super like ext4_mark_recovery_complete?
We do have protections already before we start replaying the journal,
and before we process the orphaned inode list. See the
bdev_read_only() calls in ext4_orphan_cleanup() and ext4_load_journal().
So I think we have them all covered, but let me know if you find one
that we've missed. Something that's probably worth doing is to
putting in a debugging patch that notices when thre are writes sent
down from the file systems when the block device is marked read-only,
and then running xfstests and seeing if it trips anywhere.
Cheers,
- Ted
prev parent reply other threads:[~2015-05-15 23:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-14 22:37 [PATCH] ext4: don't save the error information if the block device is read-only Theodore Ts'o
[not found] ` <CAG_9a6cSd-1VDD8zkCt7zFPbBi01a78VeOTDyi0NJuvS26XApw@mail.gmail.com>
2015-05-15 23:36 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150515233617.GA4599@thunk.org \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=mkayyash@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).