* [PATCH 1/1 linux-next] ext4: fix incorrect type argument
@ 2015-05-15 21:01 Fabian Frederick
2015-06-08 16:21 ` Theodore Ts'o
0 siblings, 1 reply; 2+ messages in thread
From: Fabian Frederick @ 2015-05-15 21:01 UTC (permalink / raw)
To: linux-kernel
Cc: Fabian Frederick, Theodore Ts'o, Andreas Dilger, linux-ext4
Fix sparse warning introduced in commit
9bd8212f981e
("ext4 crypto: add encryption policy and password salt support")
fs/ext4/ioctl.c:678:35: warning: incorrect type in argument 1
(different address spaces)
fs/ext4/ioctl.c:678:35: expected void [noderef] <asn:1>*to
fs/ext4/ioctl.c:678:35: got void *<noident>
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
fs/ext4/ioctl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c
index 2cb9e17..3c5e530 100644
--- a/fs/ext4/ioctl.c
+++ b/fs/ext4/ioctl.c
@@ -675,8 +675,8 @@ encryption_policy_out:
if (err)
return err;
}
- if (copy_to_user((void *) arg, sbi->s_es->s_encrypt_pw_salt,
- 16))
+ if (copy_to_user((void __user *) arg,
+ sbi->s_es->s_encrypt_pw_salt, 16))
return -EFAULT;
return 0;
}
--
2.4.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1 linux-next] ext4: fix incorrect type argument
2015-05-15 21:01 [PATCH 1/1 linux-next] ext4: fix incorrect type argument Fabian Frederick
@ 2015-06-08 16:21 ` Theodore Ts'o
0 siblings, 0 replies; 2+ messages in thread
From: Theodore Ts'o @ 2015-06-08 16:21 UTC (permalink / raw)
To: Fabian Frederick; +Cc: linux-kernel, Andreas Dilger, linux-ext4
On Fri, May 15, 2015 at 11:01:13PM +0200, Fabian Frederick wrote:
> Fix sparse warning introduced in commit
> 9bd8212f981e
> ("ext4 crypto: add encryption policy and password salt support")
>
> fs/ext4/ioctl.c:678:35: warning: incorrect type in argument 1
> (different address spaces)
> fs/ext4/ioctl.c:678:35: expected void [noderef] <asn:1>*to
> fs/ext4/ioctl.c:678:35: got void *<noident>
>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
Thanks for pointing this out! I'll fix this and another sparse
warning at the same time.
- Ted
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-06-08 16:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-15 21:01 [PATCH 1/1 linux-next] ext4: fix incorrect type argument Fabian Frederick
2015-06-08 16:21 ` Theodore Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).