From: Theodore Ts'o <tytso@mit.edu>
To: Jan Kara <jack@suse.com>
Cc: linux-ext4@vger.kernel.org, Ming Lei <tom.leiming@gmail.com>,
Jan Kara <jack@suse.cz>
Subject: Re: [PATCH] jbd2: Speedup jbd2_journal_dirty_metadata()
Date: Sun, 5 Jul 2015 21:54:45 -0400 [thread overview]
Message-ID: <20150706015445.GK8628@thunk.org> (raw)
In-Reply-To: <1435945032-17253-1-git-send-email-jack@suse.com>
On Fri, Jul 03, 2015 at 07:37:12PM +0200, Jan Kara wrote:
> From: Jan Kara <jack@suse.cz>
>
> It is often the case that we mark buffer as having dirty metadata when
> the buffer is already in that state (frequent for bitmaps, inode table
> blocks, superblock). Thus it is unnecessary to contend on grabbing
> journal head reference and bh_state lock. Avoid that by checking whether
> any modification to the buffer is needed before grabbing any locks or
> references.
>
> Signed-off-by: Jan Kara <jack@suse.cz>
Applied, thanks.
- Ted
prev parent reply other threads:[~2015-07-06 1:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-03 17:37 [PATCH] jbd2: Speedup jbd2_journal_dirty_metadata() Jan Kara
2015-07-06 1:54 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150706015445.GK8628@thunk.org \
--to=tytso@mit.edu \
--cc=jack@suse.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox