linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Theodore Ts'o <tytso@mit.edu>
To: Eryu Guan <guaneryu@gmail.com>
Cc: Jan Kara <jack@suse.cz>, Joseph Qi <joseph.qi@huawei.com>,
	linux-ext4@vger.kernel.org
Subject: Re: [BUG] infinite loop when unmounting ext3/4
Date: Tue, 28 Jul 2015 15:04:13 -0400	[thread overview]
Message-ID: <20150728190413.GM2851@thunk.org> (raw)
In-Reply-To: <20150728071502.GF18016@dhcp-13-216.nay.redhat.com>

On Tue, Jul 28, 2015 at 03:15:26PM +0800, Eryu Guan wrote:
> > > To fix the issue you've reported, we just need to teach
> > > jbd2_log_do_checkpoint() to cleanup all the buffers in the transactions
> > > when the journal is aborted so that journal_destroy() can proceed. I can
> > > have a look at it sometime next week unless someone beats me to it.
> > 
> > OK, attached is the patch that fixes the issue for me. Ted, can you please
> > pick it up? Thanks!
> 
> I confirmed that the attached patch fixed the infinite loop on aborted
> journal. Thanks!

Applied, thanks.

						- Ted

      reply	other threads:[~2015-07-28 19:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-15 14:30 [BUG] infinite loop when unmounting ext3/4 Eryu Guan
2015-07-16  6:18 ` Joseph Qi
2015-07-20  7:23   ` Eryu Guan
2015-07-23 20:41     ` Jan Kara
2015-07-27 19:54       ` Jan Kara
2015-07-28  7:15         ` Eryu Guan
2015-07-28 19:04           ` Theodore Ts'o [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150728190413.GM2851@thunk.org \
    --to=tytso@mit.edu \
    --cc=guaneryu@gmail.com \
    --cc=jack@suse.cz \
    --cc=joseph.qi@huawei.com \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).