From: Theodore Ts'o <tytso@mit.edu>
To: Eryu Guan <guaneryu@gmail.com>
Cc: linux-ext4@vger.kernel.org, Zirong Lang <zorro.lang@gmail.com>
Subject: Re: [PATCH] ext4: update c/mtime on truncate up
Date: Tue, 28 Jul 2015 15:09:44 -0400 [thread overview]
Message-ID: <20150728190944.GN2851@thunk.org> (raw)
In-Reply-To: <1437720998-1208-1-git-send-email-guaneryu@gmail.com>
On Fri, Jul 24, 2015 at 02:56:38PM +0800, Eryu Guan wrote:
> Commit 3da40c7b0898 ("ext4: only call ext4_truncate when size <= isize")
> introduced a bug that c/mtime is not updated on truncate up.
>
> Fix the issue by setting c/mtime explicitly in the truncate up case.
>
> Note that ftruncate(2) is not affected, so you won't see this bug using
> truncate(1) and xfs_io(1).
>
> Signed-off-by: Zirong Lang <zorro.lang@gmail.com>
> Signed-off-by: Eryu Guan <guaneryu@gmail.com>
Applied, thanks.
- Ted
prev parent reply other threads:[~2015-07-28 19:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-24 6:56 [PATCH] ext4: update c/mtime on truncate up Eryu Guan
2015-07-28 19:09 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150728190944.GN2851@thunk.org \
--to=tytso@mit.edu \
--cc=guaneryu@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=zorro.lang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).