From: Theodore Ts'o <tytso@mit.edu>
To: Daeho Jeong <daeho.jeong@samsung.com>
Cc: "linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
"daehojng@gmail.com" <daehojng@gmail.com>
Subject: Re: [PATCH] ext4, jbd2: ensure entering into panic after recording an error in JBD2 superblock
Date: Sat, 15 Aug 2015 11:20:36 -0400 [thread overview]
Message-ID: <20150815152036.GA22485@thunk.org> (raw)
In-Reply-To: <302309021.645571439185489165.JavaMail.weblogic@epmlwas07d>
On Mon, Aug 10, 2015 at 05:44:49AM +0000, Daeho Jeong wrote:
> If a EXT4 filesystem utilizes JBD2 journaling and an error occurs, the journaling
> will be aborted first and the error number will be recorded into JBD2 superblock
> and, finally, the system will enter into the panic state in "errors=panic" option.
> But, in the rare case, this sequence is little twisted like the below figure and
> it will happen that the system enters into panic state, which means the system
> reset in mobile environment, before completion of recording an error in the
> journal superblock. In this case, e2fsck cannot recognize that the filesystem
> failure occured in the previous run and the corruption wouldn't be fixed.
Applied, but please note that the patch was very badly whitespace
damaged, *despite* being base64 encoded. I had to manually apply the
patch. I also adjusted the commit description so that its width was
no more 80 columns (ideally the width should be no more than 72
columns wide).
Thanks,
- Ted
next prev parent reply other threads:[~2015-08-15 15:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-10 5:44 [PATCH] ext4, jbd2: ensure entering into panic after recording an error in JBD2 superblock Daeho Jeong
2015-08-15 15:20 ` Theodore Ts'o [this message]
2015-08-15 18:05 ` Theodore Ts'o
-- strict thread matches above, loose matches on Subject: below --
2015-08-16 6:33 Daeho Jeong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150815152036.GA22485@thunk.org \
--to=tytso@mit.edu \
--cc=daeho.jeong@samsung.com \
--cc=daehojng@gmail.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).