From: Theodore Ts'o <tytso@mit.edu>
To: Albino B Neto <bino@riseup.net>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] Fix style and return NULL
Date: Fri, 18 Sep 2015 23:48:48 -0400 [thread overview]
Message-ID: <20150919034848.GD2921@thunk.org> (raw)
In-Reply-To: <1442613662-5100-1-git-send-email-bino@riseup.net>
On Fri, Sep 18, 2015 at 07:01:02PM -0300, Albino B Neto wrote:
> Line "if (!ext4_has_metadata_csum(sb))".
>
> Second patch and sorry error.
Please don't try to correct "style" --- in fact, you've made things
worse, and in fact, you've introduced compile errors when tried to fix
"style".
You also apparently didn't bother to check and see if the patch
compiled correctly. Please *do* try to make sure you have (a) tested
your patches to make sure that they compile, and (b) at the very
*minimum* tested your patch to make sure that any code paths you have
changed has been exercised.
In addition, it is highly preferable that for ext4 changes that you
have tested them using kvm-xfstests[1] or gce-xfstests[2] before
submitting a patch. This may seem like a lot of extra work, but
unlike other parts of the kernel, if you just make the kernel crash,
it will annoy users --- but if you corrupt their data, they users tend
to get really steamed, so we have somewhat higher standards in file
system code.
Of course, if your changes cause the kernel to not even compile, users
aren't at risk of losing their data; but then you tend to annoy your
fellow kernel developers. :-)
Best regards,
- Ted
[1] https://git.kernel.org/cgit/fs/ext2/xfstests-bld.git/plain/quick-start?h=META
[2] https://git.kernel.org/cgit/fs/ext2/xfstests-bld.git/tree/kvm-xfstests/README.GCE
next prev parent reply other threads:[~2015-09-19 3:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-18 22:01 [PATCH] Fix style and return NULL Albino B Neto
2015-09-19 3:48 ` Theodore Ts'o [this message]
2015-09-21 18:24 ` Albino B Neto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150919034848.GD2921@thunk.org \
--to=tytso@mit.edu \
--cc=bino@riseup.net \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).