From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: "Theodore Ts'o" <tytso@mit.edu>
Cc: linux-ext4@vger.kernel.org
Subject: [PATCH] ext4: don't print warnings on successful MMP read completion
Date: Wed, 30 Sep 2015 10:42:56 -0700 [thread overview]
Message-ID: <20150930174256.GL10390@birch.djwong.org> (raw)
If the MMP block reads without error, don't spam dmesg with warnings.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
fs/ext4/mmp.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/fs/ext4/mmp.c b/fs/ext4/mmp.c
index 6eb1a61..7bc0873 100644
--- a/fs/ext4/mmp.c
+++ b/fs/ext4/mmp.c
@@ -104,8 +104,9 @@ static int read_mmp_block(struct super_block *sb, struct buffer_head **bh,
ret = -EINVAL;
warn_exit:
- ext4_warning(sb, "Error %d while reading MMP block %llu",
- ret, mmp_block);
+ if (ret)
+ ext4_warning(sb, "Error %d while reading MMP block %llu",
+ ret, mmp_block);
return ret;
}
next reply other threads:[~2015-09-30 17:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-30 17:42 Darrick J. Wong [this message]
2015-10-01 6:20 ` [PATCH] ext4: don't print warnings on successful MMP read completion Andreas Dilger
2015-10-01 6:26 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150930174256.GL10390@birch.djwong.org \
--to=darrick.wong@oracle.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).