From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: fstests@vger.kernel.org, xfs@oss.sgi.com,
linux-ext4@vger.kernel.org, Anna.Schumaker@netapp.com,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 03/12] generic/80[0-2]: support xfs in addition to btrfs
Date: Thu, 15 Oct 2015 02:19:44 -0700 [thread overview]
Message-ID: <20151015091944.GA13683@infradead.org> (raw)
In-Reply-To: <20151007051323.3260.60421.stgit@birch.djwong.org>
> +# this test requires the test fs support reflink...
> +#
> +_require_test_reflink()
> +{
> + case $FSTYP in
> + xfs)
> + xfs_info "${TEST_DIR}" | grep reflink=1 -c -q || _notrun "Reflink not supported by this filesystem type: $FSTYP"
> + ;;
> + btrfs)
> + true
> + ;;
> + *)
> + _notrun "Reflink not supported by this filesystem type: $FSTYP"
> + ;;
> + esac
I don't think that's a good test - we need to check if it's supported by
trying it. That'll automatically get us coverage for other file systems
like xfs.
Note that dedup should get it's own feature check, as currently hacking
nfs into this check will also run dedup tests that can't really be
supported.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2015-10-15 9:19 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-07 5:12 [RFCv3 00/12] xfstests: test the btrfs/xfs reflink/dedupe ioctls Darrick J. Wong
2015-10-07 5:13 ` [PATCH 01/12] xfs: fix merge errors in fuzzer tests Darrick J. Wong
2015-10-07 5:13 ` [PATCH 02/12] btrfs: move btrfs reflink tests to generic Darrick J. Wong
2015-10-07 5:13 ` [PATCH 03/12] generic/80[0-2]: support xfs in addition to btrfs Darrick J. Wong
2015-10-15 9:19 ` Christoph Hellwig [this message]
2015-10-15 14:41 ` Darrick J. Wong
2015-10-07 5:13 ` [PATCH 04/12] reflink: basic tests of the reflink and dedupe ioctls Darrick J. Wong
2015-10-07 5:13 ` [PATCH 05/12] reflink: test CoW behaviors of reflinked files Darrick J. Wong
2015-10-07 5:13 ` [PATCH 06/12] reflink: test the various fallocate modes Darrick J. Wong
2015-10-07 5:13 ` [PATCH 07/12] reflink: concurrent operations tests Darrick J. Wong
2015-10-07 5:13 ` [PATCH 08/12] reflink: test accuracy of free block counts Darrick J. Wong
2015-10-07 5:14 ` [PATCH 09/12] reflink: test error conditions due to bad inputs Darrick J. Wong
2015-10-07 5:14 ` [PATCH 10/12] xfs: test xfs-specific reflink pieces Darrick J. Wong
2015-10-07 5:14 ` [PATCH 11/12] reflink: test what happens when we hit resource limits Darrick J. Wong
2015-10-07 5:14 ` [PATCH 12/12] reflink: test that CoW writes fail when we're out of space Darrick J. Wong
[not found] ` <9163f8156b2742a0b003ba9fa0a26258@nebula-exfe-01.nebula.local>
2015-10-08 12:33 ` [PATCH 03/12] generic/80[0-2]: support xfs in addition to btrfs Ari Sundholm
2015-10-09 18:58 ` Darrick J. Wong
2015-11-09 7:59 ` [RFCv3 00/12] xfstests: test the btrfs/xfs reflink/dedupe ioctls Christoph Hellwig
2015-11-09 18:49 ` Darrick J. Wong
2015-11-11 13:56 ` Christoph Hellwig
2015-11-12 0:41 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151015091944.GA13683@infradead.org \
--to=hch@infradead.org \
--cc=Anna.Schumaker@netapp.com \
--cc=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).