* [PATCH 06/17] fs/ext2: remove unnecessary new_valid_dev check
[not found] <1443446807-4838-1-git-send-email-bywxiaobai@163.com>
@ 2015-09-28 13:47 ` Yaowei Bai
2015-09-28 13:50 ` [PATCH 07/17] fs/ext4: " Yaowei Bai
2015-09-28 14:21 ` [PATCH 06/17] fs/ext2: " Yaowei Bai
2 siblings, 0 replies; 5+ messages in thread
From: Yaowei Bai @ 2015-09-28 13:47 UTC (permalink / raw)
To: viro, jack; +Cc: linux-ext4, linux-fsdevel, linux-kernel
As new_valid_dev always returns 1, so !new_valid_dev check is not
needed, remove it.
Signed-off-by: Yaowei Bai <bywxiaobai@163.com>
---
fs/ext2/namei.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/fs/ext2/namei.c b/fs/ext2/namei.c
index b4841e3..3267a80 100644
--- a/fs/ext2/namei.c
+++ b/fs/ext2/namei.c
@@ -143,9 +143,6 @@ static int ext2_mknod (struct inode * dir, struct dentry *dentry, umode_t mode,
struct inode * inode;
int err;
- if (!new_valid_dev(rdev))
- return -EINVAL;
-
err = dquot_initialize(dir);
if (err)
return err;
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 07/17] fs/ext4: remove unnecessary new_valid_dev check
[not found] <1443446807-4838-1-git-send-email-bywxiaobai@163.com>
2015-09-28 13:47 ` [PATCH 06/17] fs/ext2: remove unnecessary new_valid_dev check Yaowei Bai
@ 2015-09-28 13:50 ` Yaowei Bai
2015-10-29 18:09 ` Theodore Ts'o
2015-09-28 14:21 ` [PATCH 06/17] fs/ext2: " Yaowei Bai
2 siblings, 1 reply; 5+ messages in thread
From: Yaowei Bai @ 2015-09-28 13:50 UTC (permalink / raw)
To: viro, tytso, adilger.kernel; +Cc: linux-ext4, linux-fsdevel, linux-kernel
As new_valid_dev always returns 1, so !new_valid_dev check is not
needed, remove it.
Signed-off-by: Yaowei Bai <bywxiaobai@163.com>
---
fs/ext4/namei.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
index 9f61e76..41b6cc8 100644
--- a/fs/ext4/namei.c
+++ b/fs/ext4/namei.c
@@ -2469,9 +2469,6 @@ static int ext4_mknod(struct inode *dir, struct dentry *dentry,
struct inode *inode;
int err, credits, retries = 0;
- if (!new_valid_dev(rdev))
- return -EINVAL;
-
err = dquot_initialize(dir);
if (err)
return err;
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 06/17] fs/ext2: remove unnecessary new_valid_dev check
[not found] <1443446807-4838-1-git-send-email-bywxiaobai@163.com>
2015-09-28 13:47 ` [PATCH 06/17] fs/ext2: remove unnecessary new_valid_dev check Yaowei Bai
2015-09-28 13:50 ` [PATCH 07/17] fs/ext4: " Yaowei Bai
@ 2015-09-28 14:21 ` Yaowei Bai
2 siblings, 0 replies; 5+ messages in thread
From: Yaowei Bai @ 2015-09-28 14:21 UTC (permalink / raw)
To: viro, jack; +Cc: linux-ext4, linux-fsdevel, linux-kernel
As new_valid_dev always returns 1, so !new_valid_dev check is not
needed, remove it.
Signed-off-by: Yaowei Bai <bywxiaobai@163.com>
---
fs/ext2/namei.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/fs/ext2/namei.c b/fs/ext2/namei.c
index b4841e3..3267a80 100644
--- a/fs/ext2/namei.c
+++ b/fs/ext2/namei.c
@@ -143,9 +143,6 @@ static int ext2_mknod (struct inode * dir, struct dentry *dentry, umode_t mode,
struct inode * inode;
int err;
- if (!new_valid_dev(rdev))
- return -EINVAL;
-
err = dquot_initialize(dir);
if (err)
return err;
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 07/17] fs/ext4: remove unnecessary new_valid_dev check
2015-09-28 13:50 ` [PATCH 07/17] fs/ext4: " Yaowei Bai
@ 2015-10-29 18:09 ` Theodore Ts'o
2015-10-30 1:38 ` Yaowei Bai
0 siblings, 1 reply; 5+ messages in thread
From: Theodore Ts'o @ 2015-10-29 18:09 UTC (permalink / raw)
To: Yaowei Bai; +Cc: viro, adilger.kernel, linux-ext4, linux-fsdevel, linux-kernel
On Mon, Sep 28, 2015 at 09:50:37PM +0800, Yaowei Bai wrote:
> As new_valid_dev always returns 1, so !new_valid_dev check is not
> needed, remove it.
>
> Signed-off-by: Yaowei Bai <bywxiaobai@163.com>
Thanks, applied.
- Ted
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 07/17] fs/ext4: remove unnecessary new_valid_dev check
2015-10-29 18:09 ` Theodore Ts'o
@ 2015-10-30 1:38 ` Yaowei Bai
0 siblings, 0 replies; 5+ messages in thread
From: Yaowei Bai @ 2015-10-30 1:38 UTC (permalink / raw)
To: Theodore Ts'o, viro, adilger.kernel, linux-ext4,
linux-fsdevel, linux-kernel
Cc: akpm
On Thu, Oct 29, 2015 at 02:09:01PM -0400, Theodore Ts'o wrote:
> On Mon, Sep 28, 2015 at 09:50:37PM +0800, Yaowei Bai wrote:
> > As new_valid_dev always returns 1, so !new_valid_dev check is not
> > needed, remove it.
> >
> > Signed-off-by: Yaowei Bai <bywxiaobai@163.com>
>
> Thanks, applied.
Ted, this patch has been merged into andrew's mm tree.
>
> - Ted
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-10-30 1:38 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1443446807-4838-1-git-send-email-bywxiaobai@163.com>
2015-09-28 13:47 ` [PATCH 06/17] fs/ext2: remove unnecessary new_valid_dev check Yaowei Bai
2015-09-28 13:50 ` [PATCH 07/17] fs/ext4: " Yaowei Bai
2015-10-29 18:09 ` Theodore Ts'o
2015-10-30 1:38 ` Yaowei Bai
2015-09-28 14:21 ` [PATCH 06/17] fs/ext2: " Yaowei Bai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).