public inbox for linux-ext4@vger.kernel.org
 help / color / mirror / Atom feed
From: Theodore Ts'o <tytso@mit.edu>
To: "Lennart Lövstrand" <lennart@lovstrand.com>
Cc: linux-ext4@vger.kernel.org, darrick.wong@oracle.com
Subject: Re: fuse2fs
Date: Sat, 21 Nov 2015 09:10:13 -0500	[thread overview]
Message-ID: <20151121141013.GA4741@thunk.org> (raw)
In-Reply-To: <EA601C64-3B42-4FA7-A572-6BD07443AEE1@lovstrand.com>

Hi Lennart,

Apologies for the delay in getting back to you.  Things have been very
busy this past month, and your e-mail slipped between the cracks.

> I got it to compile under OS X 10.11 with a few minor tweaks, but
> when testing it, I noticed pretty quickly that I couldn't create new
> files. I tracked it down to the UID & GID fields not being set on
> new inodes. This caused them to be owned by root in op_create, which
> in turn made its call to __op_open fail since it couldn't open the
> file as the current user, which in turn made op_create fail (even
> though the file actually was created). It seems like such a simple
> and obvious error that I'm surprised it's there and it makes me
> wonder if this code really has been used in read/write mode to any
> large extent.
> 
> Could you advise?  I notice that it's marked with "Copyright
> Oracle", so I'm assuming it was contributed by someone else and not
> actually your own code.

Yes, if you had checked the git logs, you would have seen that Darrick
contributed the code.

It looks like op_create is missing a call to set the inode uid/gid
from the fuse_context's uid/gid fields, but I'm not an expert on FUSE;
Darrick should be able to comment more intelligently on your bug
report.

> BTW, if I were to create a decent .fs package for OS X, would you be
> interested in making it part of the e2fsprogs source, or do you
> think it would be better to make it a separate distribution?  What
> kind of attribution would you like me to put into it in that case?
> My intent would be to distribute it freely & openly, of course.

I'm not sure what a ".fs package" is.  Is this some kind of spec file
ala the RPM spec file or the debian dpkg files that are used to
build a package?  If so, sure, we could put something like that in the
contrib directory along with directions of how to build a new OSX
package from source.

Cheers,

					- Ted

       reply	other threads:[~2015-11-21 14:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <EA601C64-3B42-4FA7-A572-6BD07443AEE1@lovstrand.com>
2015-11-21 14:10 ` Theodore Ts'o [this message]
2015-11-23 20:49   ` fuse2fs Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151121141013.GA4741@thunk.org \
    --to=tytso@mit.edu \
    --cc=darrick.wong@oracle.com \
    --cc=lennart@lovstrand.com \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox