From mboxrd@z Thu Jan 1 00:00:00 1970 From: Theodore Ts'o Subject: Re: fuse2fs Date: Sat, 21 Nov 2015 09:10:13 -0500 Message-ID: <20151121141013.GA4741@thunk.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-ext4@vger.kernel.org, darrick.wong@oracle.com To: Lennart =?iso-8859-1?Q?L=F6vstrand?= Return-path: Received: from imap.thunk.org ([74.207.234.97]:44360 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760877AbbKUOkl (ORCPT ); Sat, 21 Nov 2015 09:40:41 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-ext4-owner@vger.kernel.org List-ID: Hi Lennart, Apologies for the delay in getting back to you. Things have been very busy this past month, and your e-mail slipped between the cracks. > I got it to compile under OS X 10.11 with a few minor tweaks, but > when testing it, I noticed pretty quickly that I couldn't create new > files. I tracked it down to the UID & GID fields not being set on > new inodes. This caused them to be owned by root in op_create, which > in turn made its call to __op_open fail since it couldn't open the > file as the current user, which in turn made op_create fail (even > though the file actually was created). It seems like such a simple > and obvious error that I'm surprised it's there and it makes me > wonder if this code really has been used in read/write mode to any > large extent. > > Could you advise? I notice that it's marked with "Copyright > Oracle", so I'm assuming it was contributed by someone else and not > actually your own code. Yes, if you had checked the git logs, you would have seen that Darrick contributed the code. It looks like op_create is missing a call to set the inode uid/gid from the fuse_context's uid/gid fields, but I'm not an expert on FUSE; Darrick should be able to comment more intelligently on your bug report. > BTW, if I were to create a decent .fs package for OS X, would you be > interested in making it part of the e2fsprogs source, or do you > think it would be better to make it a separate distribution? What > kind of attribution would you like me to put into it in that case? > My intent would be to distribute it freely & openly, of course. I'm not sure what a ".fs package" is. Is this some kind of spec file ala the RPM spec file or the debian dpkg files that are used to build a package? If so, sure, we could put something like that in the contrib directory along with directions of how to build a new OSX package from source. Cheers, - Ted