From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: david@fromorbit.com, fstests@vger.kernel.org, xfs@oss.sgi.com,
hch@infradead.org, tao.peng@primarydata.com,
linux-ext4@vger.kernel.org, Anna.Schumaker@netapp.com,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 2/2] generic/15[78]: fix error messages in the golden output
Date: Sat, 21 Nov 2015 10:06:44 -0800 [thread overview]
Message-ID: <20151121180644.GA23916@infradead.org> (raw)
In-Reply-To: <20151121005014.20398.22316.stgit@birch.djwong.org>
> --- a/tests/generic/158.out
> +++ b/tests/generic/158.out
> Try to dedupe a device
> -XFS_IOC_FILE_EXTENT_SAME: Permission denied
> +XFS_IOC_FILE_EXTENT_SAME: Invalid argument
> Try to dedupe to a dir
> -/mnt/test-158/dir1: Is a directory
> +TEST_DIR/test-158/dir1: Is a directory
> Try to dedupe to a device
> -dedupe: Permission denied
> +dedupe: Operation not supported
> Try to dedupe to a fifo
> -dedupe: Permission denied
> +dedupe: Operation not supported
Shouldn't these be Invalid argument just like the
to a device case above or the clone case?
Otherwise looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2015-11-21 18:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-21 0:50 [PATCH v3.3 0/2] xfstests: test the nfs/cifs/btrfs/xfs reflink/dedupe ioctls Darrick J. Wong
2015-11-21 0:50 ` [PATCH 1/2] test-scripts: test migration scripts Darrick J. Wong
2015-11-21 0:50 ` [PATCH 2/2] generic/15[78]: fix error messages in the golden output Darrick J. Wong
2015-11-21 18:06 ` Christoph Hellwig [this message]
2015-11-21 18:14 ` Christoph Hellwig
2015-11-23 21:25 ` Darrick J. Wong
2015-11-24 7:41 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151121180644.GA23916@infradead.org \
--to=hch@infradead.org \
--cc=Anna.Schumaker@netapp.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=tao.peng@primarydata.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox