From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 2/2] generic/15[78]: fix error messages in the golden output Date: Sat, 21 Nov 2015 10:14:51 -0800 Message-ID: <20151121181451.GA17570@infradead.org> References: <20151121005001.20398.92856.stgit@birch.djwong.org> <20151121005014.20398.22316.stgit@birch.djwong.org> <20151121180644.GA23916@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: david@fromorbit.com, fstests@vger.kernel.org, xfs@oss.sgi.com, hch@infradead.org, tao.peng@primarydata.com, linux-ext4@vger.kernel.org, Anna.Schumaker@netapp.com, linux-btrfs@vger.kernel.org To: "Darrick J. Wong" Return-path: Content-Disposition: inline In-Reply-To: <20151121180644.GA23916@infradead.org> Sender: fstests-owner@vger.kernel.org List-Id: linux-ext4.vger.kernel.org > Shouldn't these be Invalid argument just like the > to a device case above or the clone case? E.g. something like this on top of your patch: diff --git a/tests/generic/158.out b/tests/generic/158.out index 1210429..dff3692 100644 --- a/tests/generic/158.out +++ b/tests/generic/158.out @@ -16,9 +16,9 @@ XFS_IOC_FILE_EXTENT_SAME: Invalid argument Try to dedupe to a dir TEST_DIR/test-158/dir1: Is a directory Try to dedupe to a device -dedupe: Operation not supported +dedupe: Invalid argument Try to dedupe to a fifo -dedupe: Operation not supported +dedupe: Invalid argument Try to dedupe an append-only file Dedupe two files Check scratch fs