From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Chinner Subject: Re: [PATCH] ext4: drop file_update_time from ext4_dax_fault Date: Sun, 22 Nov 2015 08:32:00 +1100 Message-ID: <20151121213159.GJ19199@dastard> References: <20151120001813.27997.41722.stgit@dwillia2-desk3.jf.intel.com> <20151120030344.GH19199@dastard> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Ted Ts'o , "linux-nvdimm@lists.01.org" , Andreas Dilger , Jan Kara , linux-fsdevel , ext4 hackers To: Dan Williams Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-ext4.vger.kernel.org On Thu, Nov 19, 2015 at 08:39:06PM -0800, Dan Williams wrote: > On Thu, Nov 19, 2015 at 7:03 PM, Dave Chinner wrote: > > On Thu, Nov 19, 2015 at 04:18:13PM -0800, Dan Williams wrote: > >> WARNING: CPU: 0 PID: 2133 at fs/fs-writeback.c:2065 __mark_inode_dirty+0x261/0x350() > >> bdi-block not registered > > ^^^^^^^^^^^^^^^^^^^^^^^^ > >> [..] > >> Call Trace: > >> [] dump_stack+0x44/0x62 > >> [] warn_slowpath_common+0x82/0xc0 > >> [] warn_slowpath_fmt+0x5c/0x80 > >> [] __mark_inode_dirty+0x261/0x350 > >> [] generic_update_time+0x79/0xd0 > >> [] file_update_time+0xbd/0x110 > >> [] ext4_dax_fault+0x68/0x110 > >> [] __do_fault+0x4e/0xf0 > >> [] handle_mm_fault+0x5e7/0x1b50 > >> [] ? handle_mm_fault+0x51/0x1b50 > >> [] __do_page_fault+0x191/0x3f0 > >> [] trace_do_page_fault+0x4f/0x120 > >> [] do_async_page_fault+0x1a/0xa0 > >> [] async_page_fault+0x28/0x30 > > > > Doesn't this indicate some problem at the block/bdi level? > > __mark_inode_dirty() should not throw warnings like this regardless > > of where it is called from... > > > > I'll look closer at how the xfs path avoids triggering this... XFS doesn't mark inodes dirty at the VFS level for inode metadata changes - dirty metadata is tracked by the journalling subsystem, not the VFS. Cheers, Dave. -- Dave Chinner david@fromorbit.com