* [PATCH] ext4: add "static" to ext4_seq_##name##_fops struct
@ 2015-11-01 16:23 Xu Cang
2015-11-26 20:52 ` Theodore Ts'o
0 siblings, 1 reply; 2+ messages in thread
From: Xu Cang @ 2015-11-01 16:23 UTC (permalink / raw)
To: linux-ext4
to fix sparse warning, add static to ext4_seq_##name##_fops struct.
diff --git a/fs/ext4/sysfs.c b/fs/ext4/sysfs.c
index 1b57c72..1420a3c 100644
--- a/fs/ext4/sysfs.c
+++ b/fs/ext4/sysfs.c
@@ -358,7 +358,7 @@ static int name##_open(struct inode *inode, struct
file *file) \
return single_open(file, ext4_seq_##name##_show, PDE_DATA(inode)); \
} \
\
-const struct file_operations ext4_seq_##name##_fops = { \
+static const struct file_operations ext4_seq_##name##_fops = { \
.owner = THIS_MODULE, \
.open = name##_open, \
.read = seq_read, \
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ext4: add "static" to ext4_seq_##name##_fops struct
2015-11-01 16:23 [PATCH] ext4: add "static" to ext4_seq_##name##_fops struct Xu Cang
@ 2015-11-26 20:52 ` Theodore Ts'o
0 siblings, 0 replies; 2+ messages in thread
From: Theodore Ts'o @ 2015-11-26 20:52 UTC (permalink / raw)
To: Xu Cang; +Cc: linux-ext4
On Sun, Nov 01, 2015 at 11:23:20AM -0500, Xu Cang wrote:
> to fix sparse warning, add static to ext4_seq_##name##_fops struct.
This is a good patch, but it's missing a Signed-off-by tag.
Please take a look at the directions in the
Documentation/SubmittingPatches file.
Many thanks,
- Ted
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-11-26 20:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-01 16:23 [PATCH] ext4: add "static" to ext4_seq_##name##_fops struct Xu Cang
2015-11-26 20:52 ` Theodore Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).