From: Dave Chinner <david@fromorbit.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-ext4@vger.kernel.org, fstests@vger.kernel.org,
linux-btrfs@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH 06/11] reflink: more tests
Date: Mon, 21 Dec 2015 17:31:11 +1100 [thread overview]
Message-ID: <20151221063111.GO19802@dastard> (raw)
In-Reply-To: <20151219091131.15320.12391.stgit@birch.djwong.org>
On Sat, Dec 19, 2015 at 01:11:31AM -0800, Darrick J. Wong wrote:
> Add more tests for unaligned copy-on-write things, and explicitly
> test the ability to pass "len == 0" to mean reflink/dedupe all
> the way to the end of the file".
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
.....
> +_cleanup()
> +{
> + cd /
> + rm -rf "$tmp".* "$TESTDIR"
> +}
.....
> +
> +TESTDIR="$TEST_DIR/test-$seq"
> +rm -rf "$TESTDIR"
> +mkdir "$TESTDIR"
This use of TESTDIR is highly confusing. When I see TESTDIR I think
that it's the mount point of the test device, not potentially some
directory on the scratch device.
I see that this occurs through lots of tests, not just these new
ones. Can you do a pass across the tests with, say, sed and rename
all these to something less confusing? e.g. "testdir", in lower
case, makes it clear that it's a local variable, not the global test
device mount point.... (i.e. test local variables are lower case,
exported test harnes variables are upper case ;)
Separate patch/pull req is fine.
Cheers,
dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2015-12-21 6:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-19 9:10 [PATCH v4 00/11] xfstests: test the nfs/cifs/btrfs/xfs reflink/dedupe ioctls Darrick J. Wong
2015-12-19 9:10 ` [PATCH 01/11] test-scripts: test migration scripts Darrick J. Wong
2015-12-19 9:11 ` [PATCH 02/11] tests: don't leave cruft behind on the TEST_MNT Darrick J. Wong
2015-12-19 9:11 ` [PATCH 03/11] generic/15[78]: fix error messages in the golden output Darrick J. Wong
2015-12-19 9:11 ` [PATCH 04/11] xfs/128: allow larger margin for disk space usage Darrick J. Wong
2015-12-19 9:11 ` [PATCH 05/11] xfs/129: require loop Darrick J. Wong
2015-12-19 9:11 ` [PATCH 06/11] reflink: more tests Darrick J. Wong
2015-12-21 6:31 ` Dave Chinner [this message]
2016-01-04 19:47 ` Darrick J. Wong
2015-12-19 9:11 ` [PATCH 07/11] reflink: test ENOSPC when expanding btrees during reflink operations Darrick J. Wong
2015-12-19 9:11 ` [PATCH 08/11] reflink: more CoW tests for reflink and dedupe Darrick J. Wong
2015-12-19 9:11 ` [PATCH 09/11] reflink: test CoW with blocksize < pagesize Darrick J. Wong
2015-12-19 9:12 ` [PATCH 10/11] reflink: test a big CoW operation Darrick J. Wong
2015-12-19 9:12 ` [PATCH 11/11] generic: create a dedupe group Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151221063111.GO19802@dastard \
--to=david@fromorbit.com \
--cc=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).